-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added on_agent_final_answer-support to Agent callback_manager #5736
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c8da098
chore: added on_agent_final_answer-support to Agent callback_manager
davidberenstein1957 268e0a4
chore: format black
davidberenstein1957 720f6a6
Merge branch 'main' into main
davidberenstein1957 55e177f
Merge branch 'main' into main
davidberenstein1957 03cea38
Merge branch 'deepset-ai:main' into main
davidberenstein1957 44ec638
run pre-commit to format file
davidberenstein1957 99ea14e
updated release notes
davidberenstein1957 666d79f
Merge pull request #1 from davidberenstein1957/feat/precommit
davidberenstein1957 84c2882
reverted sorted imports
davidberenstein1957 2467189
Merge branch 'main' into main
davidberenstein1957 49a965b
Merge branch 'main' into main
davidberenstein1957 fddc12a
Merge branch 'main' into main
anakin87 05b1828
Merge branch 'main' into main
anakin87 f3b3001
Merge branch 'main' into main
davidberenstein1957 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
releasenotes/notes/add-on_agent_final_answer_to_agent_base-7798ea8de2f43af0.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
--- | ||
enhancements: | ||
- | | ||
added support for using `on_final_answer` trough `Agent` `callback_manager` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's provide a default implementation like for all the others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZanSara what do you suggest? I did not want to do this because it might mess with the current use-cases of people.