-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added on_agent_final_answer-support to Agent callback_manager #5736
Conversation
Hello, @davidberenstein1957 and welcome!
|
@anakin87 I ran the required instructions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of nitpicks, otherwise this PR only lacks tests. Could you add some?
def on_agent_final_answer(final_answer: Dict[str, Any], **kwargs: Any) -> None: | ||
pass | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's provide a default implementation like for all the others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZanSara what do you suggest? I did not want to do this because it might mess with the current use-cases of people.
@ZanSara I wanted to implement this in a more sustainable way but was urged to wrap this up as a quick and dirty fix. Also, there don't seem to be any other tests for the |
Pull Request Test Coverage Report for Build 6458327639
💛 - Coveralls |
Hey @davidberenstein1957, sorry to keep you waiting... Although untested, this PR looks very simple and good to me. To make sure we don't break things, could you reproduce this tutorial using your branch? It would be nice if you could attach the resulting notebook to this PR... |
@anakin87, thanks for the guidance. I will make sure to test it and add the resulting notebook to this PR. Do you want me to update the notebook along with generated outputs or is a reference via Colab fine? |
Thanks! A reference via Colab is fine. |
@anakin87, I finally managed to find some time to work on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davidberenstein1957!
Related Issues
Argilla
integration forhaystack
nodes haystack-integrations#25Proposed Changes:
added on_agent_final_answer-support to Agent callback_manager
How did you test it?
N.A.
Notes for the reviewer
@anakin87
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.