Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: deserialized AWS signer for IAM auth fails #972

Closed
wants to merge 3 commits into from

Conversation

ArzelaAscoIi
Copy link
Member

Related Issues

  • fixes #issue-number

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@ArzelaAscoIi ArzelaAscoIi requested a review from a team as a code owner August 12, 2024 11:23
@ArzelaAscoIi ArzelaAscoIi requested review from anakin87 and removed request for a team August 12, 2024 11:23
@ArzelaAscoIi ArzelaAscoIi marked this pull request as draft August 12, 2024 11:23
@anakin87
Copy link
Member

anakin87 commented Aug 12, 2024

I've copied here my Slack message. 👇

I found 2 different errors:

  • as you pointed out, SentenceWindowRetrieval deserialization is wrong -> should use doc_store_class.from_dict instead of default_from_dict
  • OpenSearchDocumentStore from_dict method tries to deserialize _http_auth, but to_dict stores this info in http_auth

@anakin87
Copy link
Member

The issue was fixed (tests are passing).

@ArzelaAscoIi @FHardow feel free to close this PR if everything is OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants