You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Components that deserialize a document store through to_dict do not call from_dict on the document store, but create a new instance of it. That can be wrong if the functionality differs.
We found that problem while testing out the new IAM workflow in the OpenSearch integration together with a basic component.
The OpenSearch components don't have that problems because they are calling the DocumentStore directly.
Link can be found below.
Affected components are:
SentenceWindowRetriever
CacheChecker
FilterRetriever
Please double check this list, it was only a quick code search from my side.
Error message
No error message thrown, only found that problem while testing the IAM opensearch setup.
Expected behavior
Components that serialize a document store should also deserialize it correctly.
Describe the bug
Components that deserialize a document store through
to_dict
do not callfrom_dict
on the document store, but create a new instance of it. That can be wrong if the functionality differs.We found that problem while testing out the new IAM workflow in the OpenSearch integration together with a basic component.
The OpenSearch components don't have that problems because they are calling the DocumentStore directly.
Link can be found below.
Affected components are:
Please double check this list, it was only a quick code search from my side.
Error message
No error message thrown, only found that problem while testing the IAM opensearch setup.
Expected behavior
Components that serialize a document store should also deserialize it correctly.
Additional context
Test setup that shows that a serialized OpenSearch document store is not deserialized correctly:
deepset-ai/haystack-core-integrations#972
To Reproduce
Steps to reproduce the behavior
FAQ Check
System:
The text was updated successfully, but these errors were encountered: