Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Rename model_name to model in the Jina integration #230

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Jan 17, 2024

Related Issues:

Proposed Changes:

  • Rename model_name to model in the embedders of the Jina integration

How did you test it?

Local tests run, CI

Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ZanSara ZanSara merged commit 00a55b2 into main Jan 18, 2024
9 checks passed
@ZanSara ZanSara deleted the apply-6534-to-jina branch January 18, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants