Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Astra - fix embedding retrieval top-k limit #1210

Merged
merged 3 commits into from
Nov 25, 2024
Merged

fix: Astra - fix embedding retrieval top-k limit #1210

merged 3 commits into from
Nov 25, 2024

Conversation

basoko
Copy link
Contributor

@basoko basoko commented Nov 22, 2024 •
edited
Loading

Related Issues

Proposed Changes:

  • After upgrading the astrapy lib #1145 there is a bug that don't limit the number of results when using an embedding search. As a result of this, many more expected documents are retrieved.

How did you test it?

  • Integration test.

Notes for the reviewer

  • Add test_embedding_retrieval.py following the same pattern as in other store integrations.

Checklist

@basoko basoko requested a review from a team as a code owner November 22, 2024 09:28
@basoko basoko requested review from davidsbatista and removed request for a team November 22, 2024 09:28
@github-actions github-actions bot added integration:astra type:documentation Improvements or additions to documentation labels Nov 22, 2024
@basoko basoko force-pushed the fix-embedding-retrieval-top-k branch from e3a3f06 to 1b2efb5 Compare November 22, 2024 09:55
@davidsbatista davidsbatista changed the title Fix: Astra - fix embedding retrieval top-k limit fix: Astra - fix embedding retrieval top-k limit Nov 22, 2024
@basoko basoko force-pushed the fix-embedding-retrieval-top-k branch from 1b2efb5 to 3a61a61 Compare November 22, 2024 14:13
@davidsbatista
Copy link
Contributor

Hi @basoko, and thanks for your contribution! The changes look good to me, I will nevertheless have @Amnah199 haver another look, before approvalal.

@davidsbatista
Copy link
Contributor

@Amnah199 I've already had a look, LGTM, can you have a quick second look?

Amnah199
Amnah199 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@Amnah199 Amnah199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

davidsbatista
davidsbatista approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidsbatista davidsbatista merged commit c74bd53 into deepset-ai:main Nov 25, 2024
10 checks passed
@basoko basoko deleted the fix-embedding-retrieval-top-k branch November 25, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amnah199 Amnah199 Amnah199 approved these changes

@davidsbatista davidsbatista davidsbatista approved these changes

Assignees
No one assigned
Labels
integration:astra type:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AstraDocumentStore retrieval not filtering top-k documents and not providing a score to retrieved documents
3 participants
@basoko @davidsbatista @Amnah199