fix MicrobatchExecutionDebug message #11071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11071 +/- ##
==========================================
- Coverage 88.92% 88.86% -0.07%
==========================================
Files 183 183
Lines 23934 23941 +7
==========================================
- Hits 21283 21274 -9
- Misses 2651 2667 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
MichelleArk
commented
Dec 9, 2024
|
The tests are failing due to a bug when there is only one batch. Fix is in #11113. Once that is merged, we'll update this PR and then proceed. |
ChenyuLInx
approved these changes
Dec 9, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
* fix MicrobatchExecutionDebug message * Fix typing in `describe_batch` to convince mypy `batch_start` exists when needed --------- Co-authored-by: Quigley Malcolm <[email protected]> (cherry picked from commit fc6167a)
QMalcolm
pushed a commit
that referenced
this pull request
Dec 10, 2024
* fix MicrobatchExecutionDebug message * Fix typing in `describe_batch` to convince mypy `batch_start` exists when needed --------- Co-authored-by: Quigley Malcolm <[email protected]> (cherry picked from commit fc6167a) Co-authored-by: Michelle Ark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11111
Problem
We weren't logging the batch information for microbatch debug logs, instead we were logging a pointer to the function which gives the batch description information 🙈
Example:
Solution
Simply call the function instead of pointing at it 🙃
self.describe_batch=>self.describe_batch()Result
Checklist