Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.9.latest] fix MicrobatchExecutionDebug message #11120

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport fc6167a from #11071.

* fix MicrobatchExecutionDebug message

* Fix typing in `describe_batch` to convince mypy `batch_start` exists when needed

---------

Co-authored-by: Quigley Malcolm <[email protected]>
(cherry picked from commit fc6167a)
@github-actions github-actions bot requested a review from a team as a code owner December 10, 2024 17:13
@cla-bot cla-bot bot added the cla:yes label Dec 10, 2024
@QMalcolm
Copy link
Contributor

Closing and re-opening to get github actions to do their thing

@QMalcolm QMalcolm closed this Dec 10, 2024
@QMalcolm QMalcolm reopened this Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.13%. Comparing base (f7ab487) to head (9c652e6).
Report is 1 commits behind head on 1.9.latest.

Additional details and impacted files
@@              Coverage Diff               @@
##           1.9.latest   #11120      +/-   ##
==============================================
+ Coverage       89.12%   89.13%   +0.01%     
==============================================
  Files             183      183              
  Lines           23854    23861       +7     
==============================================
+ Hits            21259    21268       +9     
+ Misses           2595     2593       -2     
Flag Coverage Δ
integration 86.53% <81.81%> (+0.09%) ⬆️
unit 62.06% <27.27%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.06% <27.27%> (-0.01%) ⬇️
Integration Tests 86.53% <81.81%> (+0.09%) ⬆️

@QMalcolm QMalcolm merged commit ff50d1d into 1.9.latest Dec 10, 2024
60 of 61 checks passed
@QMalcolm QMalcolm deleted the backport-11071-to-1.9.latest branch December 10, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants