-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix psycopg2 install #139
Fix psycopg2 install #139
Changes from all commits
a5f4b89
f6c3507
2242da9
4158457
c3c8610
8f7c3ec
cd5fddb
4511fc4
4693357
2e557cf
9c521c1
a1ebb25
94f8834
f800814
0e76b55
1cafc5f
ff620ed
20a635c
53f07b0
7cd2ed1
020f8e9
e796512
e35bbe0
86b7a64
ea7bcd2
d23fa94
fe2cc93
7a8f47a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
hatchling<2.0 | ||
dbt-common @ git+https://github.com/dbt-labs/dbt-common.git@main | ||
dbt-adapters @ git+https://github.com/dbt-labs/dbt-adapters.git@main | ||
dbt-core @ git+https://github.com/dbt-labs/dbt-core.git@main#subdirectory=core | ||
|
@@ -12,8 +11,9 @@ dbt-databricks @ git+https://github.com/databricks/[email protected] | |
dbt-trino @ git+https://github.com/starburstdata/dbt-trino.git@master | ||
dbt-fabric @ git+https://github.com/microsoft/dbt-fabric.git@main | ||
dbt-synapse @ git+https://github.com/microsoft/dbt-synapse.git@master | ||
grpcio-status~=1.47.0 | ||
|
||
pyasn1-modules~=0.2.1 | ||
pyarrow!=12.0.1 | ||
pyarrow~=14.0.1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was also an old holdover. It looks like this change was made in the minor reqs files in |
||
pydantic~=1.10 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This got added in |
||
pyodbc==4.0.39 --no-binary pyodbc | ||
snowflake-connector-python~=3.0,!=3.0.4 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ | |
|
||
@pytest.mark.parametrize( | ||
argnames="test_version", | ||
argvalues=["0.0.0", "1.3.0", "1.4.0", "1.5.0", "1.6.0", "1.7.0b1", "1.7.0", "1.8.0b1"], | ||
argvalues=["0.0.0", "1.3.0", "1.4.0", "1.5.0", "1.6.0", "1.7.0b1", "1.7.0"], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can't currently test |
||
) | ||
def test_generate_bundle_creates_a_bundle_with_valid_version( | ||
test_version | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
from pathlib import Path | ||
import platform | ||
from semantic_version import Version | ||
import sys | ||
|
||
import pytest | ||
|
||
from release_creation.bundle.bundle_config import get_bundle_config | ||
from release_creation.bundle.create import _download_packages | ||
|
||
|
||
@pytest.mark.parametrize("test_version", ["0.0.0"]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can't currently test |
||
def test_correct_version_of_psycopg2(test_version): | ||
if sys.version_info == (3, 10) and Version.coerce(test_version) >= Version.coerce( | ||
"1.5.0" | ||
): | ||
pytest.skip("We run test for Python 3.11 with version 1.5.0+ of the bundle") | ||
|
||
bundle_configuration = get_bundle_config(Version.coerce(test_version)) | ||
_download_packages(bundle_configuration) | ||
|
||
tmp_dir = Path(bundle_configuration.py_version_tmp_path) | ||
assert tmp_dir.is_dir() | ||
psycopg2_is_found = False | ||
psycopg2_binary_is_found = False | ||
for file in tmp_dir.iterdir(): | ||
if "psycopg2" in file.name: | ||
if "psycopg2_binary" not in file.name: | ||
psycopg2_is_found = True | ||
else: | ||
psycopg2_binary_is_found = True | ||
if platform.system() == "Linux": | ||
assert psycopg2_is_found and not psycopg2_binary_is_found | ||
elif platform.system() == "Darwin": | ||
assert psycopg2_binary_is_found and not psycopg2_is_found | ||
else: | ||
assert False, f"Unexpected platform: {platform.system()}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was from older versions and no longer applies. It must have been left in here accidentally and didn't cause an issue until now. It causes a version conflict currently. The version that BQ installs is
1.62.0
. It was removed from the specific minor reqs files in1.5
.