Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix psycopg2 install #139

Merged
merged 28 commits into from
Apr 15, 2024
Merged

Fix psycopg2 install #139

merged 28 commits into from
Apr 15, 2024

Conversation

mikealfare
Copy link
Contributor

No description provided.

@mikealfare mikealfare self-assigned this Apr 4, 2024
@mikealfare mikealfare marked this pull request as draft April 4, 2024 18:39
@@ -11,7 +11,7 @@

@pytest.mark.parametrize(
argnames="test_version",
argvalues=["0.0.0", "1.3.0", "1.4.0", "1.5.0", "1.6.0", "1.7.0b1", "1.7.0", "1.8.0b1"],
argvalues=["0.0.0", "1.3.0", "1.4.0", "1.5.0", "1.6.0", "1.7.0b1", "1.7.0"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't currently test 1.8.0b1 since we know this will fail due to the metadata issue in the versions that's published to PyPI. We need to add it back once we publish the next dbt-postgres beta.

from release_creation.bundle.create import _download_packages


@pytest.mark.parametrize("test_version", ["0.0.0"])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't currently test 1.8.0b1 since we know this will fail due to the metadata issue in the versions that's published to PyPI. We need to add it once we publish the next dbt-postgres beta.

@@ -12,8 +11,9 @@ dbt-databricks @ git+https://github.com/databricks/[email protected]
dbt-trino @ git+https://github.com/starburstdata/dbt-trino.git@master
dbt-fabric @ git+https://github.com/microsoft/dbt-fabric.git@main
dbt-synapse @ git+https://github.com/microsoft/dbt-synapse.git@master
grpcio-status~=1.47.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was from older versions and no longer applies. It must have been left in here accidentally and didn't cause an issue until now. It causes a version conflict currently. The version that BQ installs is 1.62.0. It was removed from the specific minor reqs files in 1.5.

pyasn1-modules~=0.2.1
pyarrow!=12.0.1
pyarrow~=14.0.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was also an old holdover. It looks like this change was made in the minor reqs files in 1.4.

pyasn1-modules~=0.2.1
pyarrow!=12.0.1
pyarrow~=14.0.1
pydantic~=1.10
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got added in 1.4.7.

@mikealfare mikealfare marked this pull request as ready for review April 15, 2024 18:53
@mikealfare mikealfare merged commit ee1caa1 into main Apr 15, 2024
12 checks passed
@mikealfare mikealfare deleted the fix-psycopg2-install branch April 15, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] Installing psycopg2-binary instead of psycopg2
2 participants