Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShowNode and CompiledNode to PrintEvent as special case, quiet-compatible events #216

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Add ShowNode and CompiledNode to PrintEvent as special case, quiet-compatible events #216

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9dfe785
Add ShowNode and CompiledNode to PrintEvent as special case, quiet-co…
dbeatty10 Nov 5, 2024
90fb4c2
Changelog entry
dbeatty10 Nov 5, 2024
0aee79d
Merge branch 'main' into dbeatty/9840-quiet-show
dbeatty10 Nov 5, 2024
080cc9a
Update changelog entry
dbeatty10 Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Features-20241105-093150.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Features
body: Allow `dbt show` and `dbt compile` to output JSON without extra logs
dbeatty10 marked this conversation as resolved.
Show resolved Hide resolved
time: 2024-11-05T09:31:50.780898-06:00
custom:
Author: dbeatty10
Issue: "216"
4 changes: 2 additions & 2 deletions dbt_common/events/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@
from dbt_common.events.format import timestamp_to_datetime_string
from dbt_common.utils.encoding import ForgivingJSONEncoder

PRINT_EVENT_NAME = "PrintEvent"
PRINT_EVENT_NAMES = ("PrintEvent", "ShowNode", "CompiledNode")


def _is_print_event(msg: EventMsg) -> bool:
return msg.info.name == PRINT_EVENT_NAME
return msg.info.name in PRINT_EVENT_NAMES


# A Filter is a function which takes a BaseEvent and returns True if the event
Expand Down
Loading