-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ShowNode
and CompiledNode
to PrintEvent
as special case, quiet-compatible events
#216
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 68.48% 68.48%
=======================================
Files 52 52
Lines 3389 3389
=======================================
Hits 2321 2321
Misses 1068 1068
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ShowNode
and CompiledNode
to PrintEvent
as special case, quiet-compatible eventsShowNode
and CompiledNode
to PrintEvent
as special case, quiet-compatible events
for dbt-labs/dbt-core#9840 (along with dbt-labs/dbt-core#9958)
Problem
dbt --quiet show ...
doesn't print anything to stdout.There are users that would like:
dbt show
to be valid JSON containing just the data and no logs.dbt compile
to be valid SQL without any logs.It would make sense for
--quiet
to suppress the logs but allow the main content to pass through. But instead, it suppresses all logging fordbt show
anddbt compile
.Solution
For the
--quiet
CLI (orDBT_QUIET
environment variable), allow the main content to pass through fordbt show
anddbt compile
. But still suppress the rest of the logs.Extending the work in #130 to apply to the
ShowNode
andCompiledNode
events accomplishes this.🎩
Note
Once dbt-labs/dbt-core#9958 is implemented, the "Previewing node 'show_me':" and "Compiled node 'show_me' is:" portions will be dropped.
Checklist
changie new
to create a changelog entry