-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added the option to use all the stats in the conditions #357
Open
dm94
wants to merge
11
commits into
darkbot-reloaded:master
Choose a base branch
from
dm94:feat/stats
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ff0424b
feat: Added the possibility to use all the keys
dm94 ff32bd4
updated the format
dm94 fe220a2
Merge branch 'master' into feat/stats
dm94 66ab537
feat: Now returns the full list of stats
dm94 ac54900
feat: Added a tokenizer for the stats condition
dm94 db6ab87
fix: Fixed the IDE format
dm94 650678f
fix: Fixed null exception
dm94 cc4e9ff
Update src/main/java/com/github/manolo8/darkbot/config/actions/values…
dm94 5b48f0e
Update src/main/java/com/github/manolo8/darkbot/config/actions/values…
dm94 19010cd
Merge branch 'master' into feat/stats
dm94 0a19b7b
fix: FIx for the comments
dm94 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of hard-coding the bot's stats, you should be using the stat API to grab any of the registered stats. The point here is that 3rd party plugins can register their own stats and with a custom tracker update the values, and they should be possible to use here too!
Consider having a syntax for namespaced keys, so you can have:
experience
: namespace -> null (the bot's namespace), category -> any, name -> experiencedmplugin:experience
: namespace -> dmplugin, category -> any, name -> experiencedmplugin:general:experience
: namespace -> dmplugin, category -> general, name -> experienceTo implement this matching logic you can probably expose in
StatsManager
andStatsAPI
a:and use that to search for the category for the namespace/key given, if none is found defer the operation to later as the stat could've not been registered yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation done, I'm not very proud of this implementation but I can't think of any other way right now.