feat: Added the option to use all the stats in the conditions #357
Conversation
dm94
changed the title
| for (Stats.General statGeneral : Stats.General.values()) { | ||
| if (statGeneral.name().equalsIgnoreCase(key)) | ||
| return statGeneral; | ||
| } | ||
|
|
||
| for (Stats.Bot statBot : Stats.Bot.values()) { | ||
| if (statBot.name().equalsIgnoreCase(key)) | ||
| return statBot; | ||
| } | ||
|
|
||
| for (Stats.BootyKey statKey : Stats.BootyKey.values()) { | ||
| if (statKey.name().equalsIgnoreCase(key)) | ||
| return statKey; | ||
| } |
There was a problem hiding this comment.
instead of hard-coding the bot's stats, you should be using the stat API to grab any of the registered stats. The point here is that 3rd party plugins can register their own stats and with a custom tracker update the values, and they should be possible to use here too!
Consider having a syntax for namespaced keys, so you can have:
experience: namespace -> null (the bot's namespace), category -> any, name -> experience
dmplugin:experience: namespace -> dmplugin, category -> any, name -> experience
dmplugin:general:experience: namespace -> dmplugin, category -> general, name -> experience
To implement this matching logic you can probably expose in StatsManager and StatsAPI a:
public Collection<? extends StatsAPI.Key> getStatKeys() {
return Collections.unmodifiableSet(statistics.keySet());
}and use that to search for the category for the namespace/key given, if none is found defer the operation to later as the stat could've not been registered yet.
There was a problem hiding this comment.
Implementation done, I'm not very proud of this implementation but I can't think of any other way right now.
src/main/java/com/github/manolo8/darkbot/config/actions/values/StatTypeValue.java
Show resolved
Hide resolved
| } | ||
| return null; | ||
| private StatsAPI.Key getKeyFromString(String token) { | ||
| String[] tokenParts = token.split(":"); |
There was a problem hiding this comment.
| String[] tokenParts = token.split(":"); | |
| String[] tokenParts = token.split(":", 3); |
There was a problem hiding this comment.
If you don't cap it at 3, you may have a string like:
plugin:something:general:uridium
which would be parsed as
namespace=plugin, category=general, name=uridium, leaving the "something" being completely ignored. This is faulty behavior, so you either limit it to 3 splits or you throw an error if there's more than 3, but it needs to be handled
src/main/java/com/github/manolo8/darkbot/config/actions/values/StatTypeValue.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/manolo8/darkbot/config/actions/values/StatTypeValue.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/manolo8/darkbot/config/actions/values/StatTypeValue.java
Show resolved
Hide resolved
src/main/java/com/github/manolo8/darkbot/core/manager/StatsManager.java
Outdated
Show resolved
Hide resolved
…/StatTypeValue.java Co-authored-by: Pablo Herrera <[email protected]>
…/StatTypeValue.java Co-authored-by: Pablo Herrera <[email protected]>
|
I think the way it is now is the most correct way as it allows backwards compatibility to be maintained. |
No description provided.