Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ResourceType enum and associate with Resource model #232

Merged
merged 8 commits into from
Mar 18, 2024

Conversation

bendichter
Copy link
Member

fix #231

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.58%. Comparing base (e6cc5a0) to head (2f8e27f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   97.54%   97.58%   +0.04%     
==========================================
  Files          16       16              
  Lines        1669     1701      +32     
==========================================
+ Hits         1628     1660      +32     
  Misses         41       41              
Flag Coverage Δ
unittests 97.58% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder jwodder changed the title add ResourceType enum and assocaite with Resource model Add ResourceType enum and associate with Resource model Mar 16, 2024
@bendichter bendichter requested review from jwodder and satra March 16, 2024 17:51
@satra satra added patch Increment the patch version when merged release Create a release when this pr is merged labels Mar 16, 2024
@satra
Copy link
Member

satra commented Mar 16, 2024

@bendichter - since this will create a new schema you should increment that to and make the necessary changes to consts.py

Copy link
Member

@satra satra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks great. left a comment about the consts.py change to increase schema version. can be a semver patch increase.

@bendichter
Copy link
Member Author

I'm not familiar with the merge protocol here. Is this all that's needed? Should I also add an entry to the CHANGELOG.md file?

Copy link
Member

@satra satra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll approve this and wait for any comment from @jwodder before merging.

@satra
Copy link
Member

satra commented Mar 17, 2024

I'm not familiar with the merge protocol here. Is this all that's needed? Should I also add an entry to the CHANGELOG.md file?

yes that's all that was needed. CHANGELOG is autogenerated+updated on release.

@bendichter bendichter merged commit d1979c1 into master Mar 18, 2024
76 checks passed
@bendichter bendichter deleted the add_resource_type branch March 18, 2024 11:17
@bendichter
Copy link
Member Author

OK great, now what's the process for propagating this change to the medator?

@satra
Copy link
Member

satra commented Mar 18, 2024

@bendichter - dandi-archive may need a schema bump.

@satra
Copy link
Member

satra commented Mar 18, 2024

however the auto release failed in this repo, so the version of auto may need to be updated to fix that.

@jwodder
Copy link
Member

jwodder commented Mar 18, 2024

@satra I suspect the auto failure has the same solution as nipy/heudiconv#746.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource type
3 participants