-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ResourceType enum and associate with Resource model #232
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #232 +/- ##
==========================================
+ Coverage 97.54% 97.58% +0.04%
==========================================
Files 16 16
Lines 1669 1701 +32
==========================================
+ Hits 1628 1660 +32
Misses 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@bendichter - since this will create a new schema you should increment that to and make the necessary changes to consts.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks great. left a comment about the consts.py change to increase schema version. can be a semver patch increase.
I'm not familiar with the merge protocol here. Is this all that's needed? Should I also add an entry to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll approve this and wait for any comment from @jwodder before merging.
yes that's all that was needed. CHANGELOG is autogenerated+updated on release. |
OK great, now what's the process for propagating this change to the medator? |
@bendichter - dandi-archive may need a schema bump. |
however the auto release failed in this repo, so the version of auto may need to be updated to fix that. |
@satra I suspect the |
fix #231