[dagster-airlift] Python operator docs #26096
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 22, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
examples/docs_snippets/docs_snippets/integrations/airlift/operator_migration/python_operator.py
Outdated
Show resolved
Hide resolved
dpeng817
force-pushed
the
dpeng817/k8s_docs
branch
from
68f46a0
to
846e273
Compare
dpeng817
force-pushed
the
dpeng817/python_operator_docs
branch
from
4c6eb2c
to
1e187a5
Compare
Graphite Automations"Add a 'docs-to-migrate' label to PRs with docs" took an action on this PR • (11/22/24)1 label was added to this PR based on Christopher DeCarolis's automation. |
dpeng817
force-pushed
the
dpeng817/k8s_docs
branch
from
846e273
to
9bb88e7
Compare
dpeng817
force-pushed
the
dpeng817/python_operator_docs
branch
from
1e187a5
to
1bd29de
Compare
dpeng817
force-pushed
the
dpeng817/k8s_docs
branch
from
9bb88e7
to
806bc70
Compare
dpeng817
force-pushed
the
dpeng817/python_operator_docs
branch
from
1bd29de
to
8b34130
Compare
dpeng817
force-pushed
the
dpeng817/k8s_docs
branch
from
806bc70
to
09d4822
Compare
dpeng817
force-pushed
the
dpeng817/python_operator_docs
branch
from
8b34130
to
57974fd
Compare
dpeng817
force-pushed
the
dpeng817/k8s_docs
branch
from
09d4822
to
ee6dba1
Compare
dpeng817
force-pushed
the
dpeng817/python_operator_docs
branch
from
57974fd
to
1bdbb43
Compare
dpeng817
force-pushed
the
dpeng817/k8s_docs
branch
from
ee6dba1
to
7f40743
Compare
dpeng817
force-pushed
the
dpeng817/python_operator_docs
branch
from
1bdbb43
to
a6e21d8
Compare
docs/content/integrations/airlift/operator-migration/python-operator.mdx
Outdated
Show resolved
Hide resolved
dpeng817
force-pushed
the
dpeng817/k8s_docs
branch
from
7f40743
to
a8589be
Compare
dpeng817
force-pushed
the
dpeng817/python_operator_docs
branch
from
a6e21d8
to
28d1ef5
Compare
dpeng817
force-pushed
the
dpeng817/k8s_docs
branch
from
a8589be
to
a564411
Compare
dpeng817
force-pushed
the
dpeng817/python_operator_docs
branch
from
28d1ef5
to
8365a1f
Compare
This was referenced Nov 23, 2024
This was referenced Nov 23, 2024
dpeng817
force-pushed
the
dpeng817/python_operator_docs
branch
from
8365a1f
to
267d5ec
Compare
| def script_result(context: AssetExecutionContext): | ||
| return ( | ||
| PipesSubprocessClient() | ||
| .run( |
There was a problem hiding this comment.
context.op_execution_context is a property that doesn't exist on AssetExecutionContext. To get the OpExecutionContext that PipesSubprocessClient requires, use context.get_op_execution_context() instead.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
dpeng817
force-pushed
the
dpeng817/python_operator_docs
branch
from
267d5ec
to
7f90cc5
Compare
| def script_result(context: AssetExecutionContext): | ||
| return ( | ||
| PipesSubprocessClient() | ||
| .run(context=context, command="python /path/to/script.py") |
There was a problem hiding this comment.
The context parameter should be passed as context=context.op_execution_context since PipesSubprocessClient.run() expects an OpExecutionContext. The current code passes an AssetExecutionContext which will cause type errors. This can be fixed by accessing the underlying op_execution_context property.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
dpeng817
force-pushed
the
dpeng817/k8s_docs
branch
from
a564411
to
00063fc
Compare
dpeng817
force-pushed
the
dpeng817/python_operator_docs
branch
2 times, most recently
from
e7d0535
to
b84bce9
Compare
dpeng817
force-pushed
the
dpeng817/k8s_docs
branch
from
00063fc
to
a7d8d76
Compare
dpeng817
force-pushed
the
dpeng817/python_operator_docs
branch
from
b84bce9
to
3b3ee96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Changelog