[dagster-airlift] KubernetesPodOperator guide #26093
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 22, 2024
dpeng817
force-pushed
the
dpeng817/operator-migration
branch
from
cac69ac
to
e4223c1
Compare
dpeng817
force-pushed
the
dpeng817/k8s_docs
branch
from
68f46a0
to
846e273
Compare
Graphite Automations"Add a 'docs-to-migrate' label to PRs with docs" took an action on this PR • (11/22/24)1 label was added to this PR based on Christopher DeCarolis's automation. |
dpeng817
force-pushed
the
dpeng817/operator-migration
branch
from
e4223c1
to
9b8b6f4
Compare
dpeng817
force-pushed
the
dpeng817/k8s_docs
branch
from
846e273
to
9bb88e7
Compare
dpeng817
force-pushed
the
dpeng817/operator-migration
branch
from
9b8b6f4
to
d9361c3
Compare
dpeng817
force-pushed
the
dpeng817/k8s_docs
branch
from
9bb88e7
to
806bc70
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| return ( | ||
| PipesK8sClient() | ||
| .run( | ||
| context=context.op_execution_context, |
There was a problem hiding this comment.
context.op_execution_context should be replaced with context. The AssetExecutionContext type can be passed directly to PipesK8sClient.run() - it doesn't have an op_execution_context attribute.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
dpeng817
force-pushed
the
dpeng817/operator-migration
branch
from
d9361c3
to
c6068ad
Compare
dpeng817
force-pushed
the
dpeng817/k8s_docs
branch
from
806bc70
to
09d4822
Compare
docs/content/_navigation.json
Outdated
| { | ||
| "title": "Migrating a KubernetesPodOperator", | ||
| "path": "/integrations/airlift/operator-migration/kubernetes-pod-operator" | ||
| }, |
There was a problem hiding this comment.
Remove the trailing comma after the last array item - it makes the JSON invalid. The array should end with:
{
"title": "Migrating a KubernetesPodOperator",
"path": "/integrations/airlift/operator-migration/kubernetes-pod-operator"
}Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
dpeng817
force-pushed
the
dpeng817/k8s_docs
branch
3 times, most recently
from
7f40743
to
a8589be
Compare
dpeng817
force-pushed
the
dpeng817/k8s_docs
branch
from
a8589be
to
a564411
Compare
This was referenced Nov 23, 2024
dpeng817
force-pushed
the
dpeng817/k8s_docs
branch
from
a564411
to
00063fc
Compare
dpeng817
force-pushed
the
dpeng817/k8s_docs
branch
from
00063fc
to
a7d8d76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Changelog