ANTLR only allow traversal on certain expressions #26068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit af6777c. |
briantu
force-pushed
the
briantu/fix-antlr-traversal-precedence
branch
from
d804f52
to
d77e549
Compare
briantu
changed the base branch from
master
to
briantu/hookup-antlr-antlr-frontend
This was referenced Nov 21, 2024
briantu
force-pushed
the
briantu/hookup-antlr-antlr-frontend
branch
from
4ae9c9a
to
1a3b80c
Compare
briantu
force-pushed
the
briantu/fix-antlr-traversal-precedence
branch
from
d77e549
to
9b0e0d2
Compare
salazarm
reviewed
Nov 21, 2024
...odules/dagster-ui/packages/ui-core/src/asset-selection/__tests__/AntlrAssetSelection.test.ts
Outdated
Show resolved
Hide resolved
salazarm
reviewed
Nov 21, 2024
salazarm
approved these changes
Nov 21, 2024
briantu
changed the title
salazarm
reviewed
Nov 21, 2024
...odules/dagster-ui/packages/ui-core/src/asset-selection/__tests__/AntlrAssetSelection.test.ts
Show resolved
Hide resolved
briantu
force-pushed
the
briantu/hookup-antlr-antlr-frontend
branch
from
1a3b80c
to
41011f3
Compare
briantu
force-pushed
the
briantu/fix-antlr-traversal-precedence
branch
2 times, most recently
from
66b1463
to
80ac002
Compare
briantu
changed the base branch from
briantu/hookup-antlr-antlr-frontend
to
graphite-base/26068
briantu
force-pushed
the
briantu/fix-antlr-traversal-precedence
branch
from
80ac002
to
af6777c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We discovered some ambiguity caused by traversal expressions that may cause parser to return an unexpected asset selection. For example, currently the parser reads
*key:a and key:b*as*(key:a and key:b)*. We believe this is unintuitive, so we've decided to force the traversal tokens to only apply to the expression they are immediately next to.