Return error instead

dagster-io · Nov 21, 2024 · 4ae9c9a · 4ae9c9a
1 parent adfec70
commit 4ae9c9a
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/js_modules/dagster-ui/packages/ui-core/src/asset-selection/AntlrAssetSelection.ts b/js_modules/dagster-ui/packages/ui-core/src/asset-selection/AntlrAssetSelection.ts
@@ -68,7 +68,14 @@ export const parseAssetSelectionQuery = (
 export const filterAssetSelectionByQuery = (
   all_assets: AssetGraphQueryItem[],
   query: string,
-): AssetSelectionQueryResult =>
-  featureEnabled(FeatureFlag.flagAssetSelectionSyntax)
-    ? parseAssetSelectionQuery(all_assets, query)
-    : filterByQuery(all_assets, query);
+): AssetSelectionQueryResult => {
+  if (featureEnabled(FeatureFlag.flagAssetSelectionSyntax)) {
+    const result = parseAssetSelectionQuery(all_assets, query);
+    if (result instanceof Error) {
+      // fall back to old behavior
+      return filterByQuery(all_assets, query);
+    }
+    return result;
+  }
+  return filterByQuery(all_assets, query);
+};