[dagster-fivetran] Implement sync_and_poll method in FivetranClient #26061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2024
maximearmstrong
force-pushed
the
maxime/implement-base-poll-method-fivetran-client
branch
from
469b919
to
6fff27d
Compare
maximearmstrong
force-pushed
the
maxime/implement-sync-and-poll-method-fivetran-client
branch
from
0df7a52
to
4548acb
Compare
maximearmstrong
force-pushed
the
maxime/implement-base-poll-method-fivetran-client
branch
from
6fff27d
to
77163b2
Compare
maximearmstrong
force-pushed
the
maxime/implement-sync-and-poll-method-fivetran-client
branch
from
4548acb
to
1368cac
Compare
maximearmstrong
force-pushed
the
maxime/implement-base-poll-method-fivetran-client
branch
from
77163b2
to
a55e620
Compare
maximearmstrong
force-pushed
the
maxime/implement-sync-and-poll-method-fivetran-client
branch
from
1368cac
to
8610c37
Compare
maximearmstrong
force-pushed
the
maxime/implement-base-poll-method-fivetran-client
branch
from
a55e620
to
7ff0145
Compare
maximearmstrong
force-pushed
the
maxime/implement-sync-and-poll-method-fivetran-client
branch
2 times, most recently
from
7f056cc
to
946d522
Compare
This was referenced Nov 21, 2024
Open
Merged
[5/n][dagster-fivetran] Implement
FivetranWorkspaceData to FivetranConnectorTableProps method
#25797
Merged
dpeng817
reviewed
Nov 24, 2024
| test_failed_at = TEST_PREVIOUS_MAX_TIME_STR | ||
| # Set `failed_at` as more recent that `succeeded_at` if the sync and poll process is expected to fail | ||
| if not succeed_at_end: | ||
| test_succeeded_at, test_failed_at = test_failed_at, test_succeeded_at |
There was a problem hiding this comment.
this is kind of a weird way to do this but I think it's fine. Just add a comment
There was a problem hiding this comment.
I changed it in 05442c2 to make it clearer
dpeng817
approved these changes
Nov 24, 2024
|
Nice, thanks |
maximearmstrong
force-pushed
the
maxime/implement-base-poll-method-fivetran-client
branch
from
0d4c5c3
to
919e38e
Compare
maximearmstrong
force-pushed
the
maxime/implement-sync-and-poll-method-fivetran-client
branch
from
27b0a0f
to
e023cd6
Compare
maximearmstrong
force-pushed
the
maxime/implement-base-poll-method-fivetran-client
branch
from
919e38e
to
b85bbe8
Compare
maximearmstrong
force-pushed
the
maxime/implement-sync-and-poll-method-fivetran-client
branch
from
e023cd6
to
533e89a
Compare
maximearmstrong
force-pushed
the
maxime/implement-base-poll-method-fivetran-client
branch
from
b85bbe8
to
c7250c1
Compare
maximearmstrong
force-pushed
the
maxime/implement-sync-and-poll-method-fivetran-client
branch
from
533e89a
to
936186f
Compare
maximearmstrong
force-pushed
the
maxime/implement-base-poll-method-fivetran-client
branch
from
c7250c1
to
9161976
Compare
maximearmstrong
force-pushed
the
maxime/implement-sync-and-poll-method-fivetran-client
branch
from
936186f
to
5637798
Compare
maximearmstrong
force-pushed
the
maxime/implement-base-poll-method-fivetran-client
branch
from
9161976
to
13b8e6d
Compare
maximearmstrong
force-pushed
the
maxime/implement-sync-and-poll-method-fivetran-client
branch
from
5637798
to
90e1e6e
Compare
maximearmstrong
force-pushed
the
maxime/implement-base-poll-method-fivetran-client
branch
from
13b8e6d
to
f039336
Compare
maximearmstrong
force-pushed
the
maxime/implement-sync-and-poll-method-fivetran-client
branch
from
90e1e6e
to
3d7d017
Compare
maximearmstrong
force-pushed
the
maxime/implement-base-poll-method-fivetran-client
branch
from
f039336
to
4b0d41a
Compare
maximearmstrong
force-pushed
the
maxime/implement-sync-and-poll-method-fivetran-client
branch
from
3d7d017
to
45db9a9
Compare
Base automatically changed from
maxime/implement-base-poll-method-fivetran-client
to
master
November 27, 2024 14:01
maximearmstrong
force-pushed
the
maxime/implement-sync-and-poll-method-fivetran-client
branch
from
45db9a9
to
924009c
Compare
maximearmstrong
deleted the
maxime/implement-sync-and-poll-method-fivetran-client
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR uses the sync and poll methods implemented in previous PRs to implement
sync_and_pollinFivetranClient. This method will be used in a subsequent PR to materialize Fivetran assets.Tests are added to test the full sync and poll behavior.
How I Tested These Changes
Additional unit tests with BK