[dagster-tableau] Mark get_asset_key as deprecated in DagsterTableauTranslator #26028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 20, 2024
maximearmstrong
force-pushed
the
maxime/deprecate-get-asset-key-tableau-translator
branch
from
1afa7bc
to
142f9ce
Compare
benpankow
reviewed
Nov 20, 2024
| @deprecated( | ||
| breaking_version="1.10", | ||
| additional_warn_text="Use `DagsterTableauTranslator.get_asset_spec().key` instead", | ||
| ) |
There was a problem hiding this comment.
Can we alter the implementation to just return get_asset_spec(...).key?
maximearmstrong
force-pushed
the
maxime/deprecate-get-asset-key-tableau-translator
branch
from
142f9ce
to
43ea996
Compare
maximearmstrong
force-pushed
the
maxime/use-get-asset-spec-key-in-tableau-translator
branch
from
7c1d54d
to
c274578
Compare
maximearmstrong
force-pushed
the
maxime/deprecate-get-asset-key-tableau-translator
branch
from
43ea996
to
2ac721a
Compare
dpeng817
approved these changes
Nov 20, 2024
maximearmstrong
force-pushed
the
maxime/use-get-asset-spec-key-in-tableau-translator
branch
from
c274578
to
3e70494
Compare
maximearmstrong
force-pushed
the
maxime/deprecate-get-asset-key-tableau-translator
branch
from
2ac721a
to
de029db
Compare
This was referenced Nov 25, 2024
Base automatically changed from
maxime/use-get-asset-spec-key-in-tableau-translator
to
master
November 25, 2024 19:32
maximearmstrong
force-pushed
the
maxime/deprecate-get-asset-key-tableau-translator
branch
from
de029db
to
3c9210b
Compare
maximearmstrong
deleted the
maxime/deprecate-get-asset-key-tableau-translator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Mark DagsterTableauTranslator.get_asset_key as deprecated. To be removed in 1.10.
This PR stack will be merged after #25941 lands, so that
replace_attributes()can be called asAssetSpec().replace_attributes()Changelog
[dagster-tableau]
DagsterTableauTranslator.get_asset_keyis deprecated in favor ofDagsterTableauTranslator.get_asset_spec().key