[dagster-powerbi] Mark asset key methods as deprecated in DagsterPowerBITranslator #26052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 20, 2024
maximearmstrong
force-pushed
the
maxime/use-get-asset-spec-key-in-powerbi-translator
branch
from
55549ee
to
9aab097
Compare
maximearmstrong
force-pushed
the
maxime/deprecate-get-asset-key-powerbi-translator
branch
from
61cb105
to
569e267
Compare
|
Include the nice "use .get_asset_spec(...).key" message? |
dpeng817
previously requested changes
Nov 25, 2024
Base automatically changed from
maxime/use-get-asset-spec-key-in-powerbi-translator
to
master
November 25, 2024 21:17
maximearmstrong
force-pushed
the
maxime/deprecate-get-asset-key-powerbi-translator
branch
from
569e267
to
1c55f7d
Compare
dpeng817
approved these changes
Nov 27, 2024
maximearmstrong
deleted the
maxime/deprecate-get-asset-key-powerbi-translator
branch
maximearmstrong
added a commit
that referenced
this pull request
Dec 2, 2024
…sterTableauTranslator (#26140) ## Summary & Motivation See comments [here](#26052 (comment)) and [here](#26036 (review)). Same thing but for Tableau.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Like #26028 but for Power BI
Changelog
[dagster-powerbi]
DagsterPowerBITranslator.get_asset_keyis deprecated in favor ofDagsterPowerBITranslator.get_asset_spec().key