Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of the calibration and container module #78

Merged
merged 62 commits into from
Oct 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
962dc11
clean commit history :
Jul 12, 2023
517bfc7
test script
Jun 14, 2023
1631a59
add method to sort WaveformsContainer
Jun 15, 2023
cfcb0dc
-waveformContainer contructor from event list
Jun 16, 2023
e8a5e1f
user script for test ggroller
Mar 30, 2023
ec426d2
change values of pp and n in fit parameters file
Apr 11, 2023
7521510
improve test
May 17, 2023
8ca58d8
repare test
May 17, 2023
1f0b255
reduce pvalue digit in label
May 18, 2023
627363c
-add time counter to SPE fit
Jul 9, 2023
482435a
add possibility to freez parameters into minuit
Jul 9, 2023
4fa0f82
begin : redesign of the SPE fit class to speed up
Jul 12, 2023
622b94f
new skeleton for the calibration pipeline :
Sep 4, 2023
55725c0
mothers class for the maker module
Sep 7, 2023
8bb7ca1
mother class for the gain makers
Sep 7, 2023
86161c4
unchanged modeuls for the new structure
Sep 7, 2023
ebd86fc
FlatFieldSPEMaker implementation
Sep 7, 2023
408281a
photostatistic maker (not re-implemented yet)
Sep 7, 2023
2049a7c
implementation of the FFSPE fit for single run
Sep 8, 2023
32b2ba7
implementation of FF SPE gain maker
Sep 9, 2023
9ee64ca
bugfix
Sep 9, 2023
17e800c
update for nominal voltage data FF SPE fit from HHV
Sep 9, 2023
0139b7d
-bugfix
Sep 9, 2023
177e577
put I/O method in mother class
Sep 11, 2023
41c6a92
add low gain in contructor (only high gain before)
Sep 11, 2023
10793f0
typo bugfiox
Sep 11, 2023
090844c
move gain utils in one single folder
Sep 11, 2023
8596d24
bugfix nominal voltage fit
Sep 11, 2023
77f12ab
Photostatistic implementation done
Sep 11, 2023
043601d
cleaning : import, type, etc
Sep 11, 2023
c0e9358
remove old SPE fit implementation
Sep 11, 2023
992e264
makers : core module enhancement
Sep 11, 2023
211ce40
cleaning
Sep 12, 2023
8de8cff
moving container and makers in
Sep 12, 2023
808841a
folder restructuring
Sep 12, 2023
bc65fe5
cleaning after the restructuration
Sep 12, 2023
aacd51b
unit test for chargecontainer
Sep 13, 2023
72da7ad
test extractor utlis
Sep 13, 2023
d89345c
unit test CalibrationMaker and GainMakers
Sep 13, 2023
dbc56ef
unit test flatfieldSPEMakers
Sep 13, 2023
0c428bb
unit test implementation follow up
Sep 13, 2023
7db7034
mv wavefomrs in makers
Sep 13, 2023
7c3b907
code into WavefomContainers split into 2 parts : one for the data for…
Sep 14, 2023
205ac1f
move charge container into makers module
Sep 14, 2023
a43bdab
creation of mother class to charge and waveform container
Sep 14, 2023
b0ae914
follow up : factorisation waveforms and chargs Makers
Sep 14, 2023
a1eee04
display module
Sep 14, 2023
fd0e78a
finalisation of the refactorisation of the waveformsMaker
Sep 14, 2023
f5d0180
ChargesContainers I/O
Sep 15, 2023
f1c3298
update calibration class following COntainers changes
Sep 15, 2023
71976ef
bugfix according to unit tests
Sep 15, 2023
7ba1ab3
docstrings container + unit test
Sep 15, 2023
2ed495c
make container module visible
Sep 15, 2023
973a28c
small bugfix + fix unit test for makers
Sep 15, 2023
9aa08a8
docstrings makers module
Sep 17, 2023
0023b45
follow pre-commit hook
Sep 17, 2023
d0a1963
set Dirac import into methods which need it
Sep 17, 2023
272b0c5
first step to reimplement following ctapipe
Oct 16, 2023
878bb96
-removed the I/O method for containers
Oct 23, 2023
ae0edf5
-adapt charges extraction makers and waveform extraction
Oct 23, 2023
eb6bf07
-creation of the component module, which inherits from ctapipe.component
Oct 23, 2023
ecaa250
-preliminary tuto script to extract charges
Oct 23, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Environment variable needed:
export NECTARCAMDATA="path to local NectarCam data, it can contain fits.fz run files, WaveformsContainer or ChargeContainer FITS files"

Environment variables which can be defined:
Environment variables which can be defined but are optional:
export NECTARCHAIN_TEST="path to test for nectarchain"
export NECTARCHAIN_LOG="path to log for nectarchain"
export NECTARCHAIN_FIGURES="path to log figures for nectarchain"
2 changes: 1 addition & 1 deletion src/nectarchain/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
from .version import __version__

__all__ = ['__version__']
__all__ = ["__version__"]
281 changes: 0 additions & 281 deletions src/nectarchain/calibration/NectarGain/PhotoStat/PhotoStat.py

This file was deleted.

This file was deleted.

Loading