Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of the calibration and container module #78

Merged
merged 62 commits into from
Oct 26, 2023
Merged

Refactoring of the calibration and container module #78

merged 62 commits into from
Oct 26, 2023

Commits on Sep 13, 2023

  1. clean commit history : 

    -update SPE fit parameters initialization
following updates of the ctapipe extractors
-improve the limits of generated charge histogram plots
    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    962dc11 View commit details
    Browse the repository at this point in the history

  2. test script

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    517bfc7 View commit details
    Browse the repository at this point in the history

  3. add method to sort WaveformsContainer 

    and ChargesContainer following events_id
    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    1631a59 View commit details
    Browse the repository at this point in the history

  4. -waveformContainer contructor from event list

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    cfcb0dc View commit details
    Browse the repository at this point in the history

  5. user script for test ggroller

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    e8a5e1f View commit details
    Browse the repository at this point in the history

  6. change values of pp and n in fit parameters file 

     by median
    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    ec426d2 View commit details
    Browse the repository at this point in the history

  7. improve test

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    7521510 View commit details
    Browse the repository at this point in the history

  8. repare test

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    8ca58d8 View commit details
    Browse the repository at this point in the history

  9. reduce pvalue digit in label

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    1f0b255 View commit details
    Browse the repository at this point in the history

  10. -add time counter to SPE fit

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    627363c View commit details
    Browse the repository at this point in the history

  11. add possibility to freez parameters into minuit

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    482435a View commit details
    Browse the repository at this point in the history

  12. begin : redesign of the SPE fit class to speed up

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    4fa0f82 View commit details
    Browse the repository at this point in the history

  13. new skeleton for the calibration pipeline : 

    -container module for the data structure (to be extend)
-makers module to make the computation of calibration quantities
 on the data structure
    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    622b94f View commit details
    Browse the repository at this point in the history

  14. mothers class for the maker module

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    55725c0 View commit details
    Browse the repository at this point in the history

  15. mother class for the gain makers

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    8bb7ca1 View commit details
    Browse the repository at this point in the history

  16. unchanged modeuls for the new structure

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    86161c4 View commit details
    Browse the repository at this point in the history

  17. FlatFieldSPEMaker implementation

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    ebd86fc View commit details
    Browse the repository at this point in the history

  18. photostatistic maker (not re-implemented yet)

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    408281a View commit details
    Browse the repository at this point in the history

  19. implementation of the FFSPE fit for single run 

    with n and p' fixed
    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    2049a7c View commit details
    Browse the repository at this point in the history

  20. implementation of FF SPE gain maker 

    at nominal voltage
+ update of user script
    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    32b2ba7 View commit details
    Browse the repository at this point in the history

  21. bugfix 

    user script updated : FF SPE at VVH voltage (ie for single run)
    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    9ee64ca View commit details
    Browse the repository at this point in the history

  22. update for nominal voltage data FF SPE fit from HHV 

    pre-computed one
    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    17e800c View commit details
    Browse the repository at this point in the history

  23. -bugfix 

    update for nominal FF SPE fit
    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    0139b7d View commit details
    Browse the repository at this point in the history

  24. put I/O method in mother class

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    177e577 View commit details
    Browse the repository at this point in the history

  25. add low gain in contructor (only high gain before)

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    41c6a92 View commit details
    Browse the repository at this point in the history

  26. typo bugfiox

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    10793f0 View commit details
    Browse the repository at this point in the history

  27. move gain utils in one single folder

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    090844c View commit details
    Browse the repository at this point in the history

  28. bugfix nominal voltage fit 

    the fitting process continues although the initial
 parameters computation failed
    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    8596d24 View commit details
    Browse the repository at this point in the history

  29. Photostatistic implementation done

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    77f12ab View commit details
    Browse the repository at this point in the history

  30. cleaning : import, type, etc

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    043601d View commit details
    Browse the repository at this point in the history

  31. remove old SPE fit implementation

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    c0e9358 View commit details
    Browse the repository at this point in the history

  32. makers : core module enhancement 

     (docstrings, unit test)
    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    992e264 View commit details
    Browse the repository at this point in the history

  33. cleaning

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    211ce40 View commit details
    Browse the repository at this point in the history

  34. moving container and makers in 

     top of calibration directory
    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    8de8cff View commit details
    Browse the repository at this point in the history

  35. folder restructuring

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    808841a View commit details
    Browse the repository at this point in the history

  36. cleaning after the restructuration

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    bc65fe5 View commit details
    Browse the repository at this point in the history

  37. unit test for chargecontainer

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    aacd51b View commit details
    Browse the repository at this point in the history

  38. test extractor utlis

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    72da7ad View commit details
    Browse the repository at this point in the history

  39. unit test CalibrationMaker and GainMakers

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    d89345c View commit details
    Browse the repository at this point in the history

  40. unit test flatfieldSPEMakers

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    dbc56ef View commit details
    Browse the repository at this point in the history

  41. unit test implementation follow up

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    0c428bb View commit details
    Browse the repository at this point in the history

  42. mv wavefomrs in makers

    guillaume.grolleron committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    7db7034 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. code into WavefomContainers split into 2 parts : one for the data for… 

    …mat,

the other for the computation
    guillaume.grolleron committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    7c3b907 View commit details
    Browse the repository at this point in the history

  2. move charge container into makers module

    guillaume.grolleron committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    205ac1f View commit details
    Browse the repository at this point in the history

  3. creation of mother class to charge and waveform container

    guillaume.grolleron committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    a43bdab View commit details
    Browse the repository at this point in the history

  4. follow up : factorisation waveforms and chargs Makers

    guillaume.grolleron committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    b0ae914 View commit details
    Browse the repository at this point in the history

  5. display module

    guillaume.grolleron committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    a1eee04 View commit details
    Browse the repository at this point in the history

  6. finalisation of the refactorisation of the waveformsMaker 

    chargesMaker implementation
    guillaume.grolleron committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    fd0e78a View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. ChargesContainers I/O 

    cleaning
unit test for WaveformsMaker and ChargesMaker
    guillaume.grolleron committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    f5d0180 View commit details
    Browse the repository at this point in the history

  2. update calibration class following COntainers changes

    guillaume.grolleron committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    f1c3298 View commit details
    Browse the repository at this point in the history

  3. bugfix according to unit tests

    guillaume.grolleron committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    71976ef View commit details
    Browse the repository at this point in the history

  4. docstrings container + unit test

    guillaume.grolleron committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    7ba1ab3 View commit details
    Browse the repository at this point in the history

  5. make container module visible

    guillaume.grolleron committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    2ed495c View commit details
    Browse the repository at this point in the history

  6. small bugfix + fix unit test for makers

    guillaume.grolleron committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    973a28c View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. docstrings makers module

    guillaume.grolleron committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    9aa08a8 View commit details
    Browse the repository at this point in the history

  2. follow pre-commit hook

    guillaume.grolleron committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    0023b45 View commit details
    Browse the repository at this point in the history

  3. set Dirac import into methods which need it

    guillaume.grolleron committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    d0a1963 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. first step to reimplement following ctapipe 

     Tool and Components framework
    guillaume.grolleron committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    272b0c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. -removed the I/O method for containers 

        -> now we will use ctapipe HDF5TableWriter and Reader
-creation of recursive containers
    guillaume.grolleron committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    878bb96 View commit details
    Browse the repository at this point in the history

  2. -adapt charges extraction makers and waveform extraction 

    makers with the ctapipe.Tool framework
    guillaume.grolleron committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    ae0edf5 View commit details
    Browse the repository at this point in the history

  3. -creation of the component module, which inherits from ctapipe.component 

    -implementation of the NectarCAMComponent, the base class for nectrachain components,
- implementation of the ChargesComponent and WaveformsComponent
    guillaume.grolleron committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    eb6bf07 View commit details
    Browse the repository at this point in the history

  4. -preliminary tuto script to extract charges 

    or waveforms using Tool and Component classes
    guillaume.grolleron committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    ecaa250 View commit details
    Browse the repository at this point in the history