Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(oci): push helm chart package to github container registry #173

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

mwangggg
Copy link
Member

fixes: #161

@mwangggg mwangggg added feat New feature or request ci labels Jul 16, 2024
@mergify mergify bot added the safe-to-test label Jul 16, 2024
@mwangggg
Copy link
Member Author

mwangggg commented Jul 16, 2024

Signed-off-by: Andrew Azores <[email protected]>
@andrewazores andrewazores merged commit 6f0b1b9 into cryostatio:main Jul 17, 2024
5 checks passed
@andrewazores
Copy link
Member

The release got created by the workflow run with no apparent errors, but no package. Maybe it just silently failed?

@andrewazores
Copy link
Member

$ podman pull ghcr.io/cryostatio/cryostat-helm/cryostat:2.0.0-dev
Trying to pull ghcr.io/cryostatio/cryostat-helm/cryostat:2.0.0-dev...
Error: parsing image configuration: unsupported image-specific operation on artifact with type "application/vnd.cncf.helm.config.v1+json"

@andrewazores
Copy link
Member

andrewazores commented Jul 17, 2024

image

Image name looks wrong... though in @mwangggg's test, it has the same format and seems to have worked.

@andrewazores
Copy link
Member

Ah I see the problem, the package does exist but it has internal visibility. I'll figure out how to update this. I think the CI job is actually working properly.

@tthvo
Copy link
Member

tthvo commented Jul 17, 2024

Also, I think the release should not be created? Just the container image needs pushing to ghcr.io?

https://github.com/helm/chart-releaser-action?tab=readme-ov-file#inputs

The skip_upload can be set to avoid creating releases.

@andrewazores
Copy link
Member

Looks like a release still got created. The chart_version output is also not what I expected it to be.

@tthvo
Copy link
Member

tthvo commented Jul 17, 2024

Hmm, seems to be the image digest. Though, according this helm docs: https://helm.sh/docs/topics/registries/#the-push-subcommand, only registry/namespace can be specified with helm push.

The registry reference basename is inferred from the chart's name, and the tag is inferred from the chart's semantic version. This is currently a strict requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci feat New feature or request safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Upload helm charts to github packages registry
3 participants