-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(oci): helm repackaging #177
Conversation
I see charts are now available in multiple places: Helm repo:
OCI registry:
Make sense to document these on README? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks for the help figuring this out @tthvo , finally done: https://github.com/cryostatio/cryostat-helm/pkgs/container/cryostat-helm |
export POD_NAME=$(kubectl get pods -n plugin--cryostat -l "app.kubernetes.io/name=cryostat-helm,app.kubernetes.io/instance=cryostat" --sort-by=.metadata.creationTimestamp -o jsonpath="{.items[-1:].metadata.name}")
export POD_NAME=$(kubectl get pods -n plugin--cryostat -l "app.kubernetes.io/name=cryostat-helm,app.kubernetes.io/instance=cryostat" --sort-by=.metadata.creationTimestamp -o jsonpath="{.items[-1:].metadata.name}")
|
Nicee! Though, the chart name is now
|
This works for me. Small note is that if users have an expired token for |
I suppose the NOTES.txt can be updated so the message doesn't look odd like that. Publishing to quay.io might also be useful since it allows unauthenticated pulls, and I guess the README can note that ghcr.io requires authentication. |
Oh actually here I meant I can pull the image unauthenticated. Just that if there is an expired token, it fails even though the image is public :D |
I guess it can just be
|
Or we can add some annotations: https://helm.sh/docs/topics/charts/#the-chartyaml-file for example, |
See #176 #173