Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Minor dead code removal #3871

Merged
merged 3 commits into from
Oct 17, 2023
Merged

test: Minor dead code removal #3871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69c0f88
Remove CheckMachineNotExists
cfergeau Oct 5, 2023
d94a7e4
Revert "Add e2e ux required parameters to e2e makefile goal"
cfergeau Oct 16, 2023
7300d24
images: build-e2e: Remove 'ux testing' references
cfergeau Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ ifndef VERSION_TO_TEST
VERSION_TO_TEST = --crc-version=$(CRC_VERSION)+$(COMMIT_SHA)
endif
e2e:
@go test --timeout=180m $(MODULEPATH)/test/e2e -tags "$(BUILDTAGS)" --ldflags="$(VERSION_VARIABLES)" -v $(PULL_SECRET_FILE) $(BUNDLE_LOCATION) $(CRC_BINARY) $(GODOG_OPTS) $(CLEANUP_HOME) $(VERSION_TO_TEST) $(INSTALLER_PATH) $(USER_PASSWORD)
@go test --timeout=180m $(MODULEPATH)/test/e2e -tags "$(BUILDTAGS)" --ldflags="$(VERSION_VARIABLES)" -v $(PULL_SECRET_FILE) $(BUNDLE_LOCATION) $(CRC_BINARY) $(GODOG_OPTS) $(CLEANUP_HOME) $(VERSION_TO_TEST)

.PHONY: e2e-stories e2e-story-health e2e-story-marketplace e2e-story-registry
# cluster must already be running, crc must be in the path
Expand Down
2 changes: 0 additions & 2 deletions images/build-e2e/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ The container connects through ssh to the target host and copy the right binary
**RESULTS_FILE**:*(Optional). File name for results xunit results. Default value: e2e.*
**CLEANUP_HOME**:*(Optional). Cleanup crc home folder or keep as it is to run test.*
**E2E_TAG_EXPRESSION**:*(Optional). Define e2e tag expression to select tests. If empty all tests available for the platform will be executed.*
**INSTALLER_PATH**:*(Required when testing mode ux). Path on target host holding the installer*
**USER_PASSWORD**:*(Required when testing mode ux). Password for the user with privileges to run the installer*

## Samples

Expand Down
9 changes: 0 additions & 9 deletions test/extended/crc/cmd/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,15 +167,6 @@ func CheckCRCExecutableState(state string) error {
}
}

func CheckMachineNotExists() error {
expression := `.*Machine does not exist.*`
err := util.ExecuteCommand(CRC("status").ToString())
if err != nil {
return err
}
return util.CommandReturnShouldMatch("stderr", expression)
}

func DeleteCRC() error {

_ = util.ExecuteCommand(CRC("delete").ToString())
Expand Down
Loading