Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Minor dead code removal #3871

Merged
merged 3 commits into from
Oct 17, 2023
Merged

test: Minor dead code removal #3871

merged 3 commits into from
Oct 17, 2023

Conversation

cfergeau
Copy link
Contributor

This removes a 2 unused variables, and an unused function.

@cfergeau
Remove CheckMachineNotExists
69c0f88 
Its only user was removed in commit 2b7456
"e2e remove ux testing related functionality"
@cfergeau
Revert "Add e2e ux required parameters to e2e makefile goal"
d94a7e4 
This reverts commit 62aa89d.
These are no longer needed after commit 2b7456
"e2e remove ux testing related functionality"
@cfergeau
images: build-e2e: Remove 'ux testing' references
7300d24 
These variables are no longer needed after commit 2b7456 "e2e remove
ux testing related functionality"
@openshift-ci
Copy link

openshift-ci bot commented Oct 16, 2023

@cfergeau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-microshift-crc 7300d24 link true /test e2e-microshift-crc
ci/prow/e2e-crc 7300d24 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianriobo, gbraad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anjannath anjannath merged commit 0b0452f into crc-org:main Oct 17, 2023
12 of 13 checks passed
@cfergeau cfergeau deleted the e2e-cleanups branch November 8, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianriobo adrianriobo adrianriobo approved these changes

@gbraad gbraad gbraad approved these changes

@anjannath anjannath Awaiting requested review from anjannath

Assignees

@gbraad gbraad

@adrianriobo adrianriobo

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cfergeau @gbraad @adrianriobo @anjannath