-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint overhaul (pylint to ruff) #3004
Conversation
Hey @akx. Can you explain why ruff over pylint a little? |
|
@erogol Rebased on current |
2dd3a40
to
2afda54
Compare
ab26129
to
1f8a62b
Compare
da837ba
to
1e6abb3
Compare
@erogol Rebased once again... 🙂 |
... and again, following #3149... |
... and again. This also includes #3170 because it'd otherwise cause a lint failure. |
@erogol Could this get merged now? You can always disable some lints if they end up being too noisy... |
Rebased for the new month. The finetuning example that was merged in #3296 was pretty messy... |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels. |
I've merged this and the check_skip PR into our fork, thank you! :) |
This PR looks a bit big, but it's pretty straightforward if you look at the commits in isolation.
Basically, it replaces pylint and isort with the
ruff
linter, and re-enables linting in CI (now that it's not screaming an awful lot – I hope @erogol has found some peace of mind (ref. 8c1d8df)). The pylint configuration was converted with ttps://github.com/akx/pylint-to-ruff.pre-commit
is also updated, but currently runningpre-commit run --all-files
yields a ton of changes.