Fix ModelManager.list_models() #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressed the following: TTS/utils/manage.py:307:12: R1705: Unnecessary "else" after "return" (no-else-return) TTS/utils/manage.py:308:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) TTS/utils/manage.py:299:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) TTS/utils/manage.py:299:4: R0201: Method could be a function (no-self-use) TTS/utils/manage.py:314:4: R0201: Method could be a function (no-self-use)
|
|
akx
reviewed
Oct 31, 2023
| """Ask the user to agree to the terms of service""" | ||
| tos_path = os.path.join(model_full_path, "tos_agreed.txt") | ||
| if not os.path.exists(tos_path): |
There was a problem hiding this comment.
The same condition is already checked in tos_agreed(), so no need to repeat it here (and if it were kept, a return True would be necessary after the if block actually).
There was a problem hiding this comment.
Ah, I see. (Also, it seems this wouldn't have taken the COQUI_TOS_AGREED envvar into account...)
|
yeah, linting is too much for ML projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the hard-coded
model_typevariable, so that the following now returns all models, not onlytts_models:The second commit addresses the output of
make lintfor that file.