Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup request cache after timeout [SPA-1711] #482

Merged
merged 2 commits into from
Dec 21, 2023
Merged

fix: cleanup request cache after timeout [SPA-1711] #482

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b44e6c9
fix: cleanup after timeout as well
Chaoste Dec 21, 2023
a36098d
fix: add a warning log when REQUESTED_ENTITIES was not accepted
Chaoste Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/visual-sdk/src/store/EditorEntityStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,18 @@ export class EditorEntityStore extends EntityStore {
ids.forEach((id) => this.cleanupPromise(id));

unsubscribe();
} else {
console.warn('Unexpected entities received in REQUESTED_ENTITIES. Ignoring this response.')
}
}
);

const timeout = setTimeout(() => {
reject(new Error('Request for entities timed out'));
reject(new Error(`Request for entities timed out ${this.timeoutDuration}ms} for ${cacheId}`));

this.cleanupPromise(cacheId);
ids.forEach((id) => this.cleanupPromise(id));

unsubscribe();
}, this.timeoutDuration);

Expand Down