Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup request cache after timeout [SPA-1711] #482

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

Chaoste
Copy link

@Chaoste Chaoste commented Dec 21, 2023

Currently, a timed out request is kept in the request cache. So when we retry it, we directly get the same error again.

@Chaoste Chaoste changed the title fix: cleanup after timeout as well fix: cleanup after timeout [SPA-1711] Dec 21, 2023
@Chaoste Chaoste changed the title fix: cleanup after timeout [SPA-1711] fix: cleanup request cache after timeout [SPA-1711] Dec 21, 2023
Copy link
Contributor

@YvesRijckaert YvesRijckaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Chaoste Chaoste merged commit 87000b4 into canary Dec 21, 2023
5 checks passed
@Chaoste Chaoste deleted the fix/cleanup-after-timeout branch December 21, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants