-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from ffjson to json-iterator #889
Conversation
Signed-off-by: Nalin Dahyabhai <[email protected]>
Signed-off-by: Nalin Dahyabhai <[email protected]>
Holy crap! Thanks @nalind ! Let me try rebasing my PR onto this to give it some runtime with the newer VM images... |
With F34, I see one thing that appears like the tests simply need some adjusting.. I think that can be addressed in #886 so this LGTM (though I really don't fully understand the complete details). |
Hmm, looks like Go 1.16's |
@nalind Will this cause an upgrade problem? |
LGTM Depending on the question. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would be surprised. Which logic we call into to encode or decode structures should be an implementation detail that our consumers already don't have to care about outside of vendoring the deps, and the logic that reads and writes encoded data from and to files isn't changing. |
Just to be sure, could we spin up a new c/storage and get it merged upstream into Buildah and Podman early next week? |
Yup, just waiting for the dependabots to fire up. |
Per #886 (comment), replace our uses of ffjson with json-iterator.