Update to F34 and U2104

[cevich]

Also modernize main library to resemble what's used in other
containers-org repositories. Lastly, update hack/get_ci_vm.sh to use
the new shared container image.

Signed-off-by: Chris Evich [email protected]

[saschagrunert]

Hm, looks like that there are still build issues:

[+0140s] pkg/archive/archive_ffjson.go:13:2: imported and not used: "io/fs"
[+0140s] pkg/archive/archive_ffjson.go:1652:17: fs.FileMode undefined (type *v1.FFLexer has no field or method FileMode)

[cevich]

Hm, looks like that there are still build issues:

Ya, and specific to F34 (somehow...maybe since it's go 1.16?). I have no idea how to fix 😢

[cevich]

(rebased / force-pushed)

[cevich]

@rhatdan do you know what's breaking / needs fixing? Vendoring problem in Fedora? Did aufs "go away" in Ubuntu 2104?

[cevich]

[+0127s] GO111MODULE=on go build -mod=vendor -compiler gc -tags "  "  ./cmd/containers-storage
[+0133s] # github.com/containers/storage/pkg/archive
[+0133s] pkg/archive/archive_ffjson.go:13:2: imported and not used: "io/fs"
[+0133s] pkg/archive/archive_ffjson.go:1652:17: fs.FileMode undefined (type *v1.FFLexer has no field or method FileMode)
[+0136s] make: *** [Makefile:54: containers-storage] Error 2

[cevich]

Oof. I tried re-vendoring ffjson to the latest available, but still get the error. This only happens on F34 (golang 1.16) and not Ubuntu 2104 (golang 1.15.11). So I suspect it's a problem with the newwer golang version. I will attempt to report this problem upstream, but the project doesn't appear to be very active 😢

[cevich]

Opened pquerna/ffjson#262

[cevich]

Team discussion notes:

• Other containers-org projects switched to json-iter a number of years ago
• ffjson violates some golang tenements / idoms WRT marshling structs.
• json-iter does not require generating code
• Switching would likely be difficult
• There is time-pressure on this given it's blocking upgrades

[cevich]

Force-pushed after rebasing onto #889

[cevich]

rebased onto master

[rhatdan]

Looks like this needs @nalind PR for pattern matching.

[cevich]

rebased onto master

[cevich]

Oh okay it's passing now. Seems like maybe I simply need to disable aufs testing on U2104 (not supported).

[cevich]

rebased + dropped testing of AUFS in the latest Ubuntu.

[rhatdan]

LGTM
@cevich Has Ubuntu dropped support for AUFS?

[cevich]

@rhatdan that's my guess. In the prior run, that's the error message given.

[rhatdan]

@nalind @vrothberg @saschagrunert We should consider dropping support for AUFS if ubuntu has dropped it.