podman mount: ignore ErrLayerUnknown #24091
Conversation
openshift-ci
bot
added
release-note-none
approved
|
@edsantiago I hope this is the last mount race, although I have not tried reproducing for 1+ hours so I cannot be sure either. |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
When we check for a storage container mount we normally expect a ErrContainerUnknown when it does not exists. However during we check if it is actually mounted we also can get ErrLayerUnknown when the contianer was removed between the Container and Mount checks as they do not happen under the same lock. Fixes containers#23671 Signed-off-by: Paul Holzinger <[email protected]>
As shown in containers#23671 these functions can return the raw error without any useful context to the user which makes it hard to understand where things went wrong. Simply add some context to some error paths here. Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added
the
No New Tests
|
Darn. I'm sorry. Seeing it just now in rawhide root |
That failure seems totally unrelated to |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
opened a PR to address it: containers/storage#2119 |
|
/lgtm |
When we check for a storage container mount we normally expect a
ErrContainerUnknown when it does not exists. However during we check if
it is actually mounted we also can get ErrLayerUnknown when the
contianer was removed between the Container and Mount checks as they do
not happen under the same lock.
Fixes #23671
Does this PR introduce a user-facing change?