Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some comments #22370

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix some comments #22370

merged 1 commit into from
Apr 15, 2024

Conversation

fanqiaojun
Copy link
Contributor

@fanqiaojun fanqiaojun commented Apr 13, 2024

Does this PR introduce a user-facing change?

No

Fix some comments

Signed-off-by: fanqiaojun <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Apr 13, 2024
@openshift-ci openshift-ci bot added release-note and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Apr 13, 2024
@TomSweeneyRedHat
Copy link
Member

LGTM
Thanks @fanqiaojun !

@baude baude added the No New Tests Allow PR to proceed without adding regression tests label Apr 15, 2024
@baude
Copy link
Member

baude commented Apr 15, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2024
@baude
Copy link
Member

baude commented Apr 15, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, fanqiaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7eaedaf into containers:main Apr 15, 2024
93 of 94 checks passed
@edsantiago edsantiago mentioned this pull request May 15, 2024
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jul 15, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. machine No New Tests Allow PR to proceed without adding regression tests release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants