Skip to content

Commit

Permalink
Merge pull request #22370 from fanqiaojun/main
Browse files Browse the repository at this point in the history
Fix some comments
  • Loading branch information
openshift-merge-bot[bot] authored Apr 15, 2024
2 parents 5984ffc + 1600cff commit 7eaedaf
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion build_windows.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ cd podman
# Build podman.exe
.\winmake.ps1 podman-remote
# Downlaod gvproxy.exe and win-sshproxy.exe
# Download gvproxy.exe and win-sshproxy.exe
# that are needed to execute the podman client
.\winmake.ps1 win-gvproxy
```
Expand Down
2 changes: 1 addition & 1 deletion libpod/events.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func (c *Container) newExecDiedEvent(sessionID string, exitCode int) {
}
}

// netNetworkEvent creates a new event based on a network connect/disconnect
// newNetworkEvent creates a new event based on a network connect/disconnect
func (c *Container) newNetworkEvent(status events.Status, netName string) {
e := events.NewEvent(status)
e.ID = c.ID()
Expand Down
2 changes: 1 addition & 1 deletion libpod/events/events.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ func (e *Event) ToHumanReadable(truncate bool) string {
return humanFormat
}

// NewEventFromString takes stringified json and converts
// newEventFromJSONString takes stringified json and converts
// it to an event
func newEventFromJSONString(event string) (*Event, error) {
e := new(Event)
Expand Down
2 changes: 1 addition & 1 deletion libpod/healthcheck.go
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ func newHealthCheckLog(start, end time.Time, exitCode int, log string) define.He
}
}

// updatedHealthCheckStatus updates the health status of the container
// updateHealthStatus updates the health status of the container
// in the healthcheck log
func (c *Container) updateHealthStatus(status string) error {
healthCheck, err := c.getHealthCheckLog()
Expand Down
4 changes: 2 additions & 2 deletions libpod/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -1827,7 +1827,7 @@ func WithSecrets(containerSecrets []*ContainerSecret) CtrCreateOption {
}
}

// WithSecrets adds environment variable secrets to the container
// WithEnvSecrets adds environment variable secrets to the container
func WithEnvSecrets(envSecrets map[string]string) CtrCreateOption {
return func(ctr *Container) error {
ctr.config.EnvSecrets = make(map[string]*secrets.Secret)
Expand Down Expand Up @@ -2085,7 +2085,7 @@ func WithPodCgroupParent(path string) PodCreateOption {
}
}

// WithPodCgroups tells containers in this pod to use the cgroup created for
// WithPodParent tells containers in this pod to use the cgroup created for
// this pod.
// This can still be overridden at the container level by explicitly specifying
// a Cgroup parent.
Expand Down
2 changes: 1 addition & 1 deletion libpod/stats_freebsd.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func (c *Container) getPlatformContainerStats(stats *define.ContainerStats, prev
return nil
}

// getMemory limit returns the memory limit for a container
// getMemLimit returns the memory limit for a container
func (c *Container) getMemLimit() uint64 {
memLimit := uint64(math.MaxUint64)

Expand Down
2 changes: 1 addition & 1 deletion libpod/stats_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func (c *Container) getPlatformContainerStats(stats *define.ContainerStats, prev
return nil
}

// getMemory limit returns the memory limit for a container
// getMemLimit returns the memory limit for a container
func (c *Container) getMemLimit(memLimit uint64) uint64 {
si := &syscall.Sysinfo_t{}
err := syscall.Sysinfo(si)
Expand Down
2 changes: 1 addition & 1 deletion pkg/machine/update.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ func UpdatePodmanDockerSockService(mc *vmconfigs.MachineConfig) error {
command := fmt.Sprintf("'echo %q > %s'", content, ignition.PodmanDockerTmpConfPath)
args := []string{"sudo", "bash", "-c", command}
if err := CommonSSH(mc.SSH.RemoteUsername, mc.SSH.IdentityPath, mc.Name, mc.SSH.Port, args); err != nil {
logrus.Warnf("Could not not update internal docker sock config")
logrus.Warnf("Could not update internal docker sock config")
return err
}

Expand Down

0 comments on commit 7eaedaf

Please sign in to comment.