Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 5.0.0-rc5 #21986

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Bump to 5.0.0-rc5 #21986

merged 3 commits into from
Mar 8, 2024

Conversation

ashley-cui
Copy link
Member

Replaces #21970

Does this PR introduce a user-facing change?

None

@n1hility
Copy link
Member

n1hility commented Mar 7, 2024

LGTM

@ashley-cui
Copy link
Member Author

@containers/podman-maintainers PTAL and merge :)

@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm
/hold # for happy tests.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2024
@ashley-cui
Copy link
Member Author

I think my pkginstaller PR broke Mac tests, taking a look now. :(

@TomSweeneyRedHat
Copy link
Member

Almost time for dinner here @ashley-cui , I'll check back later this evening.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2024
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024
@ashley-cui
Copy link
Member Author

Thanks @TomSweeneyRedHat for keeping an eye on it :) Hopefully I found the fix, fingers crossed. A slash-lgtm whenever would be helpful!

Building arm podman needs to be the last thing built in the OSX cross task. The Mac tests rely this Podman binary to run, and the CI Mac is ARM-based

Signed-off-by: Ashley Cui <[email protected]>
Signed-off-by: Ashley Cui <[email protected]>
Signed-off-by: Ashley Cui <[email protected]>
@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm
/hold # for happy tests then GTG

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2024
@ashley-cui
Copy link
Member Author

Heading out for a sec, will finish up the release once I'm back

@TomSweeneyRedHat
Copy link
Member

the fedora-39--aarch64 rootless host sqlite failed with a timeout in the "start simple machine" test:

[+1348s]   Machine "cff8bc694aaa" started successfully
[+1348s]   /var/tmp/go/src/github.com/containers/podman/bin/podman-remote machine stop cff8bc694aaa
[+1348s]   Waiting for VM to exit...
[+1350s]   Machine "cff8bc694aaa" stopped successfully
[+1350s]   /var/tmp/go/src/github.com/containers/podman/bin/podman-remote machine start cff8bc694aaa --quiet
[+1590s]   [FAILED] Timed out after 240.001s.
[+1590s]   Expected process to exit.  It did not.
[+1590s]   In [It] at: /var/tmp/go/src/github.com/containers/podman/pkg/machine/e2e/config_test.go:56 @ 03/08/24 00:33:32.1
[+1590s] 
[+1590s]   Full Stack Trace
[+1590s]     github.com/containers/podman/v5/pkg/machine/e2e_test.(*machineSession).waitWithTimeout(0x40002aa580?, 0x142f7a0?)
[+1590s]     	/var/tmp/go/src/github.com/containers/podman/pkg/machine/e2e/config_test.go:56 +0xc8
[+1590s]     github.com/containers/podman/v5/pkg/machine/e2e_test.runWrapper({0x4000556840, 0x3e}, {0x40005ce340, 0x4, 0x4}, 0x0?, 0x1)
[+1590s]     	/var/tmp/go/src/github.com/containers/podman/pkg/machine/e2e/config_test.go:175 +0x2cc
[+1590s]     github.com/containers/podman/v5/pkg/machine/e2e_test.(*machineTestBuilder).run(...)
[+1590s]     	/var/tmp/go/src/github.com/containers/podman/pkg/machine/e2e/config_test.go:159
[+1590s]     github.com/containers/podman/v5/pkg/machine/e2e_test.glob..func14.3()
[+1590s]     	/var/tmp/go/src/github.com/containers/podman/pkg/machine/e2e/start_test.go:54 +0x798
[+1590s]   < Exit [It] start simple machine - /var/tmp/go/src/github.com/containers/podman/pkg/machine/e2e/start_test.go:24 @ 03/08/24 00:33:32.1 (5m10.32s)
[+1590s]   > Enter [AfterEach] podman machine start - /var/tmp/go/src/github.com/containers/podman/pkg/machine/e2e/start_test.go:20 @ 03/08/24 00:33:32.1
[+1590s]   /var/tmp/go/src/github.com/containers/podman/bin/podman-remote machine rm --force cff8bc694aaa
[+1830s]   [FAILED] Timed out after 240.000s.
[+1830s]   Expected process to exit.  It did not.
[+1830s]

I'll restart, I don't see any changes in there that should have caused that.

@TomSweeneyRedHat
Copy link
Member

@ashley-cui the "Optional Release Test" is failing due to the -dev tag. I think that can be ignored, everything else is green. I'm good if you concur and hit the shiny "Merge pull request" with the Merge Hammer.

@ashley-cui
Copy link
Member Author

I think it should merge without that test! Thanks Tom!

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1cbedfb into containers:main Mar 8, 2024
94 of 95 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jun 7, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jun 7, 2024
@ashley-cui ashley-cui deleted the 500rc5 branch June 17, 2024 14:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants