-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to 5.0.0-rc5 #21986
Bump to 5.0.0-rc5 #21986
Conversation
LGTM |
@containers/podman-maintainers PTAL and merge :) |
LGTM |
/lgtm |
I think my pkginstaller PR broke Mac tests, taking a look now. :( |
Almost time for dinner here @ashley-cui , I'll check back later this evening. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @TomSweeneyRedHat for keeping an eye on it :) Hopefully I found the fix, fingers crossed. A slash-lgtm whenever would be helpful! |
Building arm podman needs to be the last thing built in the OSX cross task. The Mac tests rely this Podman binary to run, and the CI Mac is ARM-based Signed-off-by: Ashley Cui <[email protected]>
Signed-off-by: Ashley Cui <[email protected]>
Signed-off-by: Ashley Cui <[email protected]>
LGTM |
/lgtm |
Heading out for a sec, will finish up the release once I'm back |
the fedora-39--aarch64 rootless host sqlite failed with a timeout in the "start simple machine" test:
I'll restart, I don't see any changes in there that should have caused that. |
@ashley-cui the "Optional Release Test" is failing due to the |
I think it should merge without that test! Thanks Tom! /hold cancel |
1cbedfb
into
containers:main
Replaces #21970
Does this PR introduce a user-facing change?