Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to v5.0.0-rc5 #21970

Closed
wants to merge 2 commits into from
Closed

Bump to v5.0.0-rc5 #21970

wants to merge 2 commits into from

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Mar 7, 2024

Does this PR introduce a user-facing change?

None

lsm5 added 2 commits March 7, 2024 16:22
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5
Copy link
Member Author

lsm5 commented Mar 7, 2024

@ashley-cui @TomSweeneyRedHat let me know whenever we're good to proceed with this.

@Luap99
Copy link
Member

Luap99 commented Mar 7, 2024

I think we should wait for buildah vendor dance, tests on containers/buildah#5385 are at least passing.

@lsm5 lsm5 marked this pull request as draft March 7, 2024 11:04
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2024
@lsm5
Copy link
Member Author

lsm5 commented Mar 7, 2024

waiting on #21975

@lsm5
Copy link
Member Author

lsm5 commented Mar 7, 2024

waiting on #21978 and #21973

@TomSweeneyRedHat
Copy link
Member

LGTM
once rebased and the "Wait For" PR's clear.

@ashley-cui
Copy link
Member

Last wait-for PR: #21985

@ashley-cui
Copy link
Member

All required PR's merged. I think @lsm5 is done for the day, I'll see if I can get this PR rebased but if not I'll open a new one.

@ashley-cui ashley-cui changed the title [skip-ci] v5.0.0-rc5 Bump to v5.0.0-rc5 Mar 7, 2024
@ashley-cui ashley-cui marked this pull request as ready for review March 7, 2024 21:17
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2024
@ashley-cui ashley-cui mentioned this pull request Mar 7, 2024
@ashley-cui
Copy link
Member

Opened #21986 since it's 3am for @lsm5

@ashley-cui ashley-cui closed this Mar 7, 2024
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jun 6, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jun 6, 2024
@lsm5 lsm5 deleted the 500rc5 branch October 25, 2024 11:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants