Fix progress bar for decompressGzWithSparse and vendor CopySparse #21521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this needs a rebase. |
l0rd
force-pushed
the
progbar-n-copysparse
branch
2 times, most recently
from
8be1ce2 to
2526b8d
Compare
Done |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, l0rd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM but i would prefer #21508 to merge first ... it looks like it also flaked, so i'll restart that job |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
l0rd
force-pushed
the
progbar-n-copysparse
branch
from
2526b8d to
0839d62
Compare
Re-enabled the code to show the progress bar when decompressing a gz image (e.g. fedora-coreos-*-applehv.*.raw.gz). Vendored github.com/crc-org/crc/v2/pkg/os to use its `CopySparse` instead of pkg/machine/compression/copy.go (that has been deleted). [NO NEW TESTS NEEDED] Signed-off-by: Mario Loriedo <[email protected]>
l0rd
force-pushed
the
progbar-n-copysparse
branch
from
0839d62 to
f886ca0
Compare
|
@baude it looks like everything is green |
|
/lgtm |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-bot
bot
merged this pull request
into
containers:machine-dev-5
85 checks passed
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?