Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gomod: Vendor crc-org/crc dependency #21527

Closed
wants to merge 0 commits into from

Conversation

cfergeau
Copy link
Contributor

@cfergeau cfergeau commented Feb 6, 2024

This PR fixes go mod tidy, and vendors the crc code.
This is a follow-up to #21505

Does this PR introduce a user-facing change?

None

@cfergeau cfergeau changed the base branch from main to machine-dev-5 February 6, 2024 09:34
@cfergeau
Copy link
Contributor Author

cfergeau commented Feb 6, 2024

I see Mario already did this in #21521.

@cfergeau cfergeau closed this Feb 6, 2024
@baude baude reopened this Feb 6, 2024
@baude
Copy link
Member

baude commented Feb 6, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@cfergeau
Copy link
Contributor Author

cfergeau commented Feb 6, 2024

Packit fails with pkg/machine/compression/decompress.go:63:12: undefined: CopySparse
The only occurrence of CopySparse in the machine-dev-5 branch is changed to crcos.CopySparse in this PR, and it's not at line 63.
I don't know how to re-run the packit builds.

@cfergeau
Copy link
Contributor Author

cfergeau commented Feb 6, 2024

/packit rebuild-failed

@baude baude force-pushed the machine-dev-5 branch 6 times, most recently from f1d430b to 8099ef9 Compare February 6, 2024 19:04
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2024
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cfergeau
Copy link
Contributor Author

cfergeau commented Feb 7, 2024

I see Mario already did this in #21521.

This PR went in first, I'll close this one, and file a new PR against main to fix go mod tidy

@cfergeau cfergeau closed this Feb 7, 2024
@cfergeau cfergeau deleted the vendor-crc branch February 7, 2024 08:45
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label May 8, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. machine needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants