Ignore the error when running podman machine ssh <command>
#21207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luap99
reviewed
Jan 9, 2024
cmd/podman/machine/ssh.go
Outdated
| @@ -57,10 +57,8 @@ func ssh(cmd *cobra.Command, args []string) error { | |||
| // provided the VM name. If so, we check. The VM name, | |||
| // if provided, must be in args[0]. | |||
| if len(args) > 0 { | |||
| // Ignore the error, See https://github.com/containers/podman/issues/21183#issuecomment-1879713572 | |||
| validVM, err = provider.IsValidVMName(args[0]) | |||
There was a problem hiding this comment.
Suggested change
| validVM, err = provider.IsValidVMName(args[0]) | |
| validVM, _ = provider.IsValidVMName(args[0]) |
To pass the linter
There was a problem hiding this comment.
Thanks! Fix the code as suggested.
|
LGTM once comment is addressed |
Signed-off-by: Shion Tanaka <[email protected]>
tnk4on
force-pushed
the
fix-podman-machine-ssh-command
branch
from
a1e3ff2 to
83fa484
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, tnk4on The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit adaf3ca
into
containers:main
91 of 92 checks passed
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the error that occurs when executing a command without a machine name when using podman-machine-default.
Fixes: #21183 (and fix PR #21114)
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?