Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make binding options more consistent #21087

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Make options more consistent

6ccc833
Select commit
Loading
Failed to load commit list.
Open

Make binding options more consistent #21087

Make options more consistent
6ccc833
Select commit
Loading
Failed to load commit list.
Cirrus CI / Validate fedora-39 Build failed Dec 24, 2023 in 5m 33s

Task Summary

Instruction main failed in 03:55

Details

✅ 00:33 clone
✅ 01:02 setup
❌ 03:55 main

VERSION=1.55.2 ./hack/install_golangci.sh
Installing golangci-lint v1.55.2 into ./bin/golangci-lint
golangci/golangci-lint info checking GitHub for tag 'v1.55.2'
golangci/golangci-lint info found version: 1.55.2 for v1.55.2/linux/amd64
golangci/golangci-lint info installed ./bin/golangci-lint
hack/golangci-lint.sh run

Running golangci-lint for tunnel
Build Tags tunnel: apparmor,seccomp,selinux,remote
Skipped directories tunnel: pkg/api,pkg/domain/infra/abi

Running golangci-lint for abi
Build Tags abi: apparmor,seccomp,selinux,systemd
Skipped directories abi:
Linting vs commit '7dc7cbfd9b0440ddc86e210a2272fdaccd6376bb'
/root/.local/bin/pre-commit run -a
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.git.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.git.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
Mixed line ending........................................................Passed
check BOM - deprecated: use fix-byte-order-marker........................Passed
Check that executables have shebangs.....................................Passed
Check for merge conflicts................................................Passed
Check Yaml...............................................................Passed
Validating vs commit '7dc7cbfd9b0440ddc86e210a2272fdaccd6376bb'
GIT_CHECK_EXCLUDE="./vendor:./test/tools/vendor:docs/make.bat:test/buildah-bud/buildah-tests.diff:test/e2e/quadlet/remap-keep-id2.container" ./test/tools/build/git-validation -run short-subject -range 7dc7cbfd9b0440ddc86e210a2272fdaccd6376bb..HEAD
time="2023-12-24T17:05:05-06:00" level=info msg="using commit range: 7dc7cbfd9b0440ddc86e210a2272fdaccd6376bb..HEAD"
 * 6ccc833db "Make options more consistent" ... PASS
# Check if the files can be loaded by the shell
. completions/bash/podman
if [ -x /bin/zsh ]; then /bin/zsh completions/zsh/_podman; fi
if [ -x /bin/fish ]; then /bin/fish completions/fish/podman.fish; fi
hack/man-page-checker
hack/xref-helpmsgs-manpages
hack/man-page-table-check
hack/swagger-check
contrib/cirrus/pr-should-include-tests
pr-should-include-tests: PR does not include changes in the 'tests' directory

Please write a regression test for what you're fixing. Even if it
seems trivial or obvious, try to add a test that will prevent
regressions.

If your change is minor, feel free to piggyback on already-written
tests, possibly just adding a small step to a similar existing test.
Every second counts in CI.

If your commit really, truly does not need tests, you can proceed
by adding '[NO NEW TESTS NEEDED]' to the body of your commit message.
Please think carefully before doing so.
make: *** [Makefile:700: tests-included] Error 1

Exit status: 2