Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make binding options more consistent #21087

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make binding options more consistent #21087

wants to merge 1 commit into from

Conversation

Crypto89
Copy link

@Crypto89 Crypto89 commented Dec 24, 2023 •
edited
Loading

  • Add missing nil checks for binding function options
  • Remove default binding options when they're not being used

Does this PR introduce a user-facing change?

None

@Crypto89
Make options more consistent
6ccc833 
* Add missing nil checking on functions that were missing nil checks
* Remove default options when they're not being used

Signed-off-by: Jorn Wijnands <[email protected]>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 24, 2023

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Dec 24, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Crypto89
Once this PR has been reviewed and has the lgtm label, please assign mheon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Dec 26, 2023

You either need to add tests or specify [no new tests needed] in the description message above.

Also I believe all of these bindings are automatically created.

run
make generate-bindings

And see if it changes all of your changes back.

Luap99
Luap99 reviewed Jan 3, 2024
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change LGTM please add [NO NEW TESTS NEEDED] to your commit message and repush

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2024
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luap99 Luap99 Luap99 left review comments

Assignees
No one assigned
Labels
do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Crypto89 @rhatdan @openshift-merge-robot @Luap99