[CI:BUILD] rpm: hard dependency on gvisor-tap-vsock-gvforwarder #19953
Conversation
openshift-ci
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
depends on containers/gvisor-tap-vsock#268 |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@martinpitt revdeps failed. seeing this elsewhere? |
whoops ignore me. Looks like it's because of the change I made. |
|
The revdep tests should pass once the gvisor-tap-vsock change is merged. |
| @@ -37,7 +37,7 @@ | |||
| # include it. Official rawhide should be able to fetch the last active build of | |||
| # gvproxy, the min version requirement has been removed to allow it. | |||
| # Ref: https://bugzilla.redhat.com/show_bug.cgi?id=2224434 | |||
| %if !%{defined copr_username} && 0%{?fedora} <= 38 | |||
| %if !%{defined copr_username} && 0%{?fedora} <= 37 | |||
There was a problem hiding this comment.
is this version down grade correct?
There was a problem hiding this comment.
yes, that's intentional. gvproxy is an independent package for Fedora 38 and higher.
|
@lsm5: Yes, "nothing provides gvisor-tap-vsock-gvforwarder". Nevertheless, big thanks for the notification! Wrt. that, automatic notifications have a high chance of landing next Tuesday 🎉 packit/packit-service#2182 |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
We don't need to make the change for f37. So, I'll revise this PR a bit. |
lsm5
force-pushed
the
gvforwarder
branch
2 times, most recently
from
d16be77 to
a5519cd
Compare
With containers/gvisor-tap-vsock#268, gvforwarder is now provided via the subpackage `gvisor-tap-vsock-gvforwarder`. FCOS needs this gvforwarder, hence the hard dependency. This change is only intended for f38 and higher. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <[email protected]>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
the revdep failure should go away once containers/gvisor-tap-vsock#271 is merged. I didn't see any conflict with the rpms built on that PR and the one in fedora. |
|
LGTM |
|
the gvisor PR has been merged. I'll wait a while and rerun the revdep tests here to ensure we're green. |
|
really weird why the rpm conflict still occurs on f39 but not on rawhide and f38. Looking.. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@lsm5 : For the F38 run , vsock-gvforwarder was taken from your COPR: but for the F39 run it came from Fedora: Presumably because the podman-next COPR's most recent build is 6:0.7.0-1.20230914182756041449.main.39.g9ebd937 , i.e. the 1.2023.. is smaller than Fedora's -6 revision. However, I don't know about these "6:" vs. "103:" prefixes. Are these epochs? But an epoch of "103:" sounds pretty absurd. Or are these |
|
Our TF workaround hack landed, so feel free to retry all failed packit tests in recent PRs (I can't unfortunately) |
|
obsoleted by #20039 . f39 didn't have gvisor build earlier which is why the f39 test failed. @martinpitt yes the 102/103 were set as absurdly high epochs for copr builds to override default packages. Is |
github-actions
bot
added
the
locked - please file new issue/PR
With containers/gvisor-tap-vsock#268, gvforwarder is now provided via the subpackage
gvisor-tap-vsock-gvforwarder. FCOS needs this gvforwarder, hence the hard dependency.gvisor-tap-vsock is a separate package for f38, so the subpackage conditional has been adjusted to fit that.
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?