Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmf: Hack around Testing Farm's tag-repository priority #1410

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

martinpitt
Copy link
Member

TF runs add the Fedora tag repository with priority=9. This breaks upstream reverse dependency tests, as that repository will then win over our "main builds" COPR and thus run tests against a mismatching cockpit-podman rpm.

Counter the hack by dropping the tag repo priority and reinstalling cockpit-podman.


See e.g. containers/podman#19953 and all other recent upstream podman PRs, where tests fail like this , because

podman-4.7.0~dev-1.20230913192200752553.pr19953.1753.38e069f70.fc38.x86_64
cockpit-podman-75-1.fc38.noarch

i.e. this is an outdated Fedora build (not even 76, which is in stable!), instead of the main build.

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Sep 15, 2023
@martinpitt martinpitt changed the title fmf: Hack around Testing Farm's ta-repository priority fmf: Hack around Testing Farm's tag-repository priority Sep 15, 2023
TF runs add the Fedora tag repository with `priority=9`. This breaks
upstream reverse dependency tests, as that repository will then win over
our "main builds" COPR and thus run tests against a mismatching
cockpit-podman rpm.

Counter the hack by dropping the tag repo priority and reinstalling
cockpit-podman.
@martinpitt
Copy link
Member Author

I'm testing this in cockpit-project/cockpit#19332

@thrix see your recent slack discussion. This is a quick hack to stop breaking all of podman's PRs. We'd have to do the same for cockpit itself to stop breaking udisks, but it's less pressing. If/once there's a more TF-global way of fixing this, we can revert this again. Thanks!

@martinpitt
Copy link
Member Author

Test in cockpit-project/cockpit#19332 was successful:

+ for f in $(grep -l -r 'testing-farm-tag-repository' /etc/yum.repos.d)
+ sed -i /priority/d /etc/yum.repos.d/tag-repository.repo
+ dnf update -y cockpit-podman
[...]
Running transaction
  Preparing        :                                                        1/1 
  Upgrading        : cockpit-podman-76-1.20230914050413208140.main.8.g315   1/2 
  Cleanup          : cockpit-podman-76-1.fc38.noarch                        2/2 
  Verifying        : cockpit-podman-76-1.20230914050413208140.main.8.g315   1/2 
  Verifying        : cockpit-podman-76-1.fc38.noarch                        2/2 

Upgraded:
  cockpit-podman-76-1.20230914050413208140.main.8.g315448d.fc38.noarch          

👍

This will also fix cockpit's own revdeps runs.

@martinpitt martinpitt requested a review from jelly September 15, 2023 04:10
Copy link
Member

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit akward, as we have to hack it in every project. But it should work.

@jelly jelly merged commit 5ab52df into main Sep 15, 2023
@jelly jelly deleted the tf-hack branch September 15, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants