-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
man pages: docker differences #14917
Comments
Podman supports this as NOOP and hides it. AFAIK we always support gpus?
We have --dns-opt, interesting that nobody noticed this yet.
No idea what this is but looks related to --hostname.
AFAIK this is deprecated but still supported by podman.
This is deprecated for a long time in docker so podman never supported it.
No clue about this but this sounds scary to me.
I think the podman I did not looked at everything but this is definitely an interesting find. At least some of them are easy enough to fix. |
Great work @edsantiago |
@vrothberg @ashley-cui @cdoern @baude Intern heaven above... |
🤣 To synchronize work, please drop a comment when starting to fix a flag. First come, first serve, but this way we can avoid duplicate work. |
To add a bit more to what @Luap99 did...
|
If these are low enough priority, I would like to pick away at these after hours |
I can start off later today with |
@karthikelango137, If you're looking for work to do :) |
Footnote: should anyone wish to run the script themselves, the following diff is necessary because of slightly different index 7c07a4f01..c3edac148 100755
--- a/hack/xref-helpmsgs-manpages
+++ b/hack/xref-helpmsgs-manpages
@@ -230,8 +230,8 @@ sub podman_help {
# ....
#
# Start by identifying the section we're in...
- if ($line =~ /^Available\s+(Commands):/) {
- $section = lc $1;
+ if ($line =~ /^(Available\s+)?(Commands):/) {
+ $section = lc $2;
}
elsif ($line =~ /^(Options):/) {
$section = lc $1; |
Belated followup: @mheon this was addressed in #14916 just now (yesterday/today). Presumably if I rerun the script right now (which I'm way too lazy to do), the above warning will be gone. |
Added a checklist of the ones that are either done or intentionally not done. |
I will grab |
I will take 'docker rmi --help' lists '--no-prune', which is not in docs/source/markdown/podman-rmi.1.md |
Awesome. |
Task for containers#14917 Podman will now push all tags for a given image when -a or --all-tags is specified. Signed-off-by: byarbrough <[email protected]>
A friendly reminder that this issue had no activity for 30 days. |
Fixes one of the issues found in containers#14917 Signed-off-by: Daniel J Walsh <[email protected]>
Other cases we have added to make third party tools that are executing podman as an alias of Docker to work, even if the option is a noop. |
#14949 closed due to difficulties in containers/common#1099 |
--insecure and --verbose flags for docker compatibility --tls-verify for syntax compatibility and allow users to inspect manifests at remote Container Registiries without requiring tls. Helps fix: containers#14917 Signed-off-by: Daniel J Walsh <[email protected]>
Did you mean to close this? Today's run shows the following differences:
This is the updated command line; script diffs from earlier comment still necessary: $ PODMAN=/usr/bin/docker hack/xref-helpmsgs-manpages 2>&1 |\
grep -v 'but not --help' |\
sed -e 's/^xref-helpmsgs-manpages: .podman / - [ ] docker /' \
-e 's/ --help. lists ./ /' -e 's/., which.*$// |
NO I Did not, we might need to fix our script a little to handle the hidden options.
|
The hidden options are, by definition, not listed in the man page. I'm acting on the assumption that we're almost done with these, and (fingers crossed) won't need to perform this exercise again. If we do need to repeat this, I guess I'll need to define and maintain a hardcoded list of exceptions. I will defer that problem for the day it's needed 😉 |
Your updated lists seems to be missing some of the original ones that are still not fixed. |
Any ways I did not intend to close this and will work off the original list. |
Long-term followup to containers#14917. This adds a new one-off script, to be run periodically, which runs our man-page crossref against docker, highlighting commands and options that docker lists in its --help but we don't list in our man pages. Signed-off-by: Ed Santiago <[email protected]>
Closing in favor of #16543 |
Per request from @rhatdan I ran the man-page xref script against
moby-engine
. Here are the results, comparing to main @ 72d13c5:(The reason for the grep is that podman has options like
-a
,-l
everywhere, andpodman build
andrun
have oodles of options that docker doesn't have. The purpose of this exercise was to find options that docker lists in its--help
that are not documented in podman man pages).The text was updated successfully, but these errors were encountered: