Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility support for --debug flag from docker #15317

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Aug 15, 2022

This is another fix for #14917

Signed-off-by: Daniel J Walsh [email protected]

Does this PR introduce a user-facing change?

Podman now supports --debug, -D on the command line for Docker compatibility.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2022
@mheon
Copy link
Member

mheon commented Aug 15, 2022

LGTM

@rhatdan rhatdan changed the title Add compatibility support for --debug -D flag from docker Add compatibility support for --debug flag from docker Aug 15, 2022
@rhatdan
Copy link
Member Author

rhatdan commented Aug 15, 2022

BTW I can't do -D since it conflicts with -D in podman build. @Luap99 is there anyway to do this for everything except podman build?

@edsantiago
Copy link
Member

LGTM but leaving open in case someone can answer the -D question.

@rhatdan
Copy link
Member Author

rhatdan commented Aug 16, 2022

I think we should merge and handle -D separately.

@mheon
Copy link
Member

mheon commented Aug 16, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2022
@openshift-merge-robot openshift-merge-robot merged commit 3dace12 into containers:main Aug 16, 2022
@rhatdan rhatdan deleted the debug branch December 1, 2022 22:01
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants