Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing -l equivalent option for --log-level #14939

Closed
wants to merge 1 commit into from

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jul 14, 2022

Needed for Docker compatibility.

Signed-off-by: Daniel J Walsh [email protected]

Does this PR introduce a user-facing change?

podman now supports -l as a shorthand option for --log-level

Needed for Docker compatibility.

Signed-off-by: Daniel J Walsh <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2022
@rhatdan
Copy link
Member Author

rhatdan commented Jul 14, 2022

Found with #14917

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will conflict with the --latest, -l option most subcommands have, there can be unwanted consequences.

@rhatdan
Copy link
Member Author

rhatdan commented Jul 14, 2022

Ok, I was wondering if this would conflict. Cobra can not handle it.

@rhatdan rhatdan closed this Jul 14, 2022
@Luap99
Copy link
Member

Luap99 commented Jul 14, 2022

Ok, I was wondering if this would conflict. Cobra can not handle it.

I think you can make it work if you define it as local flag but then it would only accept it as podman --log-level ... command and not podman command --log-level ... and therefore could break people. I am sure there is a way to make it work but likely not worth the time unless someone complains loud enough.

@rhatdan
Copy link
Member Author

rhatdan commented Jul 14, 2022

I would doubt people use podman command --log-level (And I would prefer that they didn't) But I agree this is not important enough to catch anyones attention up to now.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants