Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rich dep to setup.cfg #353

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

umohnani8
Copy link
Member

@umohnani8 umohnani8 commented Dec 11, 2023

Fixes #352

Signed-off-by: Urvashi Mohnani <[email protected]>
Copy link
Contributor

openshift-ci bot commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Dec 11, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 11, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit d6342f8 into containers:main Dec 11, 2023
12 of 13 checks passed
@umohnani8
Copy link
Member Author

/cherry-pick release-4.8

@openshift-cherrypick-robot
Copy link
Collaborator

@umohnani8: only containers org members may request cherry picks. You can still do the cherry-pick manually.

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@umohnani8
Copy link
Member Author

@rhatdan are you able to request the cherry-pick? I am shown as an owner in the containers org but seem to can't trigger the cherry-pick

@rhatdan
Copy link
Member

rhatdan commented Dec 11, 2023

/cherry-pick release-4.8

@openshift-cherrypick-robot
Copy link
Collaborator

@rhatdan: new pull request created: #354

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing dependency ?
3 participants